notmuch/lib/parse-sexp.cc, branch 0.34.1thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.34.12021-09-05T00:07:19Zlib/parse-sexp: apply macros2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:41Zurn:sha1:551254eb76c9bb558078f04f21df1f6089cb03d6
Macros implement lazy evaluation and lexical scope. The former is
needed to make certain natural constructs work sensibly (e.g. (tag
,param)) but the latter is mainly future-proofing in case the DSL is
is extended to allow local bindings.
For technical background, see chapters 6 and 17 of [1] (or some other
intermediate programming languages textbook).
[1] http://cs.brown.edu/courses/cs173/2012/book/
lib/parse-sexp: thread environment argument through parser2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:40Zurn:sha1:3eca7fcf10a63e642e627539442271872fca58fd
No functionality change, just an extra argument carried everywhere.
lib/parse-sexp: support saved s-expression queries2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:39Zurn:sha1:9b9eb1d8bd6464f044facef9507c5988c3d953ca
It turns out there is not really much code in query-fp.cc useful for
supporting the new syntax. The code we could potentially factor out
amounts to calling notmuch_database_get_config; both the key
construction and the parsing of the results are specific to the query
syntax involved.
lib/parse-sexp: handle saved queries2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:37Zurn:sha1:6ab2d9b1a2e62b76960df8e80ff2a45d9c6a8551
This provides functionality analogous to query: in the Xapian
QueryParser based parser. Perhaps counterintuitively, the saved
queries currently have to be in the original query syntax (i.e. not
s-expressions).
lib/parse-sexp: parse user headers2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:35Zurn:sha1:a07ef8abf5248c1128ddc75b8139ae807a88abd9
One subtle aspect is the replacement of _find_prefix with
_notmuch_database_prefix, which understands user headers. Otherwise
the code mainly consists of creating a fake prefix record (since the
user prefixes are not in the prefix table) and error handling.
lib/parse-sexp: support infix subqueries2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:34Zurn:sha1:cc5992a30470222791c24849da04a3c0403ecce5
This is necessary so that programs can take infix syntax queries from
a user and use the sexp query syntax to construct e.g. a refinement of
that query.
lib/parse-sexp: expand queries2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:33Zurn:sha1:afe85e65786df1df9abf261393b4b4e6e2e86009
The code here is just gluing together _notmuch_query_expand with the
existing sexp parser infrastructure.
lib/thread-fp: factor out query expansion, rewrite in Xapian2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:32Zurn:sha1:4083fd8bec7a34cf9c6a722b7dd511e0d31712f6
It will be convenient not to have to construct a notmuch query object
when parsing subqueries, so the commit rewrites the query
expansion (currently only used for thread:{} queries) using only
Xapian. As a bonus it seems about 15% faster in initial experiments.
lib/parse-sexp: support regular expressions2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:29Zurn:sha1:1870b3ae4bae5e68296e63acc81965eea04a1a7a
At least to the degree that the Xapian QueryParser based parser
also supports them. Support short alias 'rx' as it seems to make more
complex queries nicer to read.
lib/parse-sexp: handle unprefixed terms.2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:26Zurn:sha1:bafc307190f694bb3c9dd6dee8af1bae49225529
This is equivalent to adding the same field name "" for multiple
prefixes in the Xapian query parser, but we have to explicitely
construct the resulting query.