notmuch/lib/query.cc, branch 0.34.1 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.34.1 2021-09-05T00:07:19Z lib/thread-fp: factor out query expansion, rewrite in Xapian 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:32Z urn:sha1:4083fd8bec7a34cf9c6a722b7dd511e0d31712f6 It will be convenient not to have to construct a notmuch query object when parsing subqueries, so the commit rewrites the query expansion (currently only used for thread:{} queries) using only Xapian. As a bonus it seems about 15% faster in initial experiments. lib/query: factor out _notmuch_query_string_to_xapian_query 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:31Z urn:sha1:b3bbaf1bc27d79b8191d296998f695be5be3146a When dealing with recursive queries (i.e. thread:{foo}) it turns out to be useful just to deal with the underlying Xapian objects, and not wrap them in notmuch objects. lib: generate actual Xapian query for "*" and "" 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:30Z urn:sha1:c62f3f77a7eeda57cff8c5c66e86d39ae3c38aad The previous code had the somewhat bizarre effect that the (notmuch specific) query string was "*" (interpreted as MatchAll) and the allegedly parsed xapian_query was "MatchNothing". This commit also reduces code duplication. lib/query: generalize exclude handling to s-expression queries 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:27Z urn:sha1:0b98ad5e4ef6b0345f28143243de1170c5c3df54 In fact most of the code path is in common, only the caching of terms in the query needs to be added for s-expression queries. lib/parse-sexp: parse single terms and the empty list. 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:16Z urn:sha1:be7e83de96b706af418fc9f139ded4d50bf342f6 There is not much of a parser here yet, but it already does some useful error reporting. Most functionality sketched in the documentation is not implemented yet; detailed documentation will follow with the implementation. lib: define notmuch_query_create_with_syntax 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:13Z urn:sha1:c4f2f33a50643b41e6dbf0519c563ae7db48beab Set the parsing syntax when the (notmuch) query object is created. Initially the library always returns a trivial query that matches all messages when using s-expression syntax. It seems better to select the syntax at query creation time because the lazy parsing is an implementation detail. lib: split notmuch_query_create 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:12Z urn:sha1:34733fa25ed3ad8bd48621d66b7877af3426f544 Most of the function will be re-usable when creating a query from an s-expression. lib: run uncrustify 2019-06-14T10:41:27Z uncrustify david@tethera.net 2019-06-13T10:55:35Z urn:sha1:2b62ca2e3b786beca8d89fa737bda0b49faa638d This is the result of running $ uncrustify --replace --config ../devel/uncrustify.cfg *.c *.h *.cc in the lib directory lib: work around xapian bug with get_mset(0,0, x) 2018-04-27T01:14:59Z David Bremner david@tethera.net 2018-04-06T11:43:07Z urn:sha1:64831e8016fcc9877c0dc8e855ec24583cac34ef At least Fedora28 triggers this Xapian bug due to some toolchain change . https://bugzilla.redhat.com/show_bug.cgi?id=1546162 The underlying bug is fixed in xapian commit f92e2a936c1592, and should be fixed in Xapian 1.4.6 lib: convert notmuch_bool_t to stdbool internally 2017-10-10T01:27:16Z Jani Nikula jani@nikula.org 2017-10-07T08:44:05Z urn:sha1:008a5e92eb157e2bb8622cb2fbf644deba5ba4b4 C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the lib internally to stdbool.