notmuch/lib/thread.cc, branch 0.2

lib: search_threads: Fix nested search to handle original search of "*"

2010-04-15T21:54:40Z

When constructing a thread, we usually run a nested query to find all messages in the thread that match the original search string. However, we need to have special-case handling of an original search string of "*" now that that is a supported means of specifying all messages. The special-case ends up bein quite simple---we do less work, (just skipping the nested search since we know that all messages must match). I had been wanting to write this identical code to more efficiently handle "notmuch search thread:" which was previously running two identical searches. So that case is now more efficient as well.

fix obvious cut and paste error

2010-04-07T01:55:56Z

the wrong variable is checked for success of an allocation Signed-off-by: Dirk Hohndel

emacs: Fix the notmuch-search-authors-width variable.

2010-03-31T20:32:00Z

This variable existed previously, but wasn't actually used for anything.

lib: Rename iterator functions to prepare for reverse iteration.

2010-03-09T17:22:29Z

We rename 'has_more' to 'valid' so that it can function whether iterating in a forward or reverse direction. We also rename 'advance' to 'move_to_next' to setup parallel naming with the proposed functions 'move_to_first', 'move_to_last', and 'move_to_previous'.

correct message flag enum value so that it matches the type

2009-11-28T04:50:59Z

As per Carl's request, this patch corrects the only value defined under the notmuch_message_flag_t enum typedef to match the name of the type. Signed-off-by: Bart Trojanowski

have _notmuch_thread_create mark which messages matched the query

2009-11-28T01:07:06Z

When _notmuch_thread_create() is given a query string, it can return more messages than just those matching the query. To distinguish those that matched the query expression, the MATCHING_SEARCH flag is set appropriately. Signed-off-by: Bart Trojanowski

lib/query: Drop the first and max_messages arguments from search_messages.

2009-11-24T04:25:13Z

These only existed to support the chunky-searching hack, but that was recently dropped anyway.

Typsos

2009-11-18T11:21:36Z

notmuch search: Change default search order to be newest messages first.

2009-11-18T04:58:30Z

This is what most people want for a _search_ command. It's often different for actually reading mail in an inbox, (where it makes more sense to have results displayed in chronological order), but in such a case, ther user is likely using an interface that can simply pass the --sort=oldest-first option to "notmuch search". Here we're also change the sort enum from NOTMUCH_SORT_DATE and NOTMUCH_SORT_DATE_REVERSE to NOTMUCH_SORT_OLDEST_FIRST and NOTMUCH_SORT_NEWEST_FIRST. Similarly we replace the --reverse option to "notmuch search" with two options: --sort=oldest-first and --sort=newest-first. Finally, these changes are all tracked in the emacs interface, (which has no change in its behavior).

Fix "too many open files" bug by closing message files when done with them.

2009-11-18T02:37:13Z

The message file header parsing code parses only enough of the file to find the desired header fields, then it leaves the file open until the next header parsing call or when the message is no longer in use. If a large number of messages end up being active, this will quickly run out of file descriptors. Here, we add support to explicitly close the message file within a message, (_notmuch_message_close) and call that from thread construction code. Signed-off-by: Keith Packard Edited-by: Carl Worth : Many portions of Keith's original patch have since been solved other ways, (such as the code that changed the handling of the In-Reply-To header). So the final version is clean enough that I think even Keith would be happy to have his name on it.