notmuch/lib/thread.cc, branch 0.5

lib: Eliminate some redundant includes of xapian.h

2010-11-02T06:24:40Z

Most files including this already include database-private.h which includes xapian.h already.

lib: Add some missing static qualifiers.

2010-11-02T04:58:43Z

These various functions and data are all used only locally, so should be marked static. Ensuring we get these right will avoid us accidentally leaking unintended symbols through the library interface.

Fix SEGV in _thread_cleanup_author if author ends with ', '

2010-04-27T23:34:27Z

Admittedly, an author name ending in ',' guarantees this is spam, and indeed this was triggered by a spam email, but that doesn't mean we shouldn't handle this case correctly. We now check that there is actually a component of the name (presumably the first name) after the comma in the author name. Signed-off-by: Dirk Hohndel

lib: Re-implement moving of thread authors.

2010-04-27T08:48:03Z

Just before releasing 0.3 we received reports of crashes that were bisected to the commit adding thread-author moving. Sure enough, valgrind pointed to buffer overruns in _thread_move_matched_author. Rather than trying to make sense of all the by strncpy, strchr, +1, and +2 of that code, I reimplemented thread-author ordering with a pair of hash tables and an array. Valgrind is at least happy now on the test cases it was complaining about previously.

Simple attempt to display author names in a friendlier way

2010-04-26T18:45:29Z

This patch only addresses the typical Outlook/Exchange case where we have "Last, First" or "Last, First MI" . In the future we should be more fexible as to the formats we recognize, but for now we address this one as it is the Exchange default setting and therefore the most common one. Signed-off-by: Dirk Hohndel

Reorder displayed names of thread authors

2010-04-26T18:45:00Z

When displaying threads as result of a search it makes sense to list those authors first who match the search. The matching authors are separated from the non-matching ones with a '|' instead of a ',' Imagine the default "+inbox" query. Those mails in the thread that match the query are actually "new" (whatever that means). And some people seem to think that it would be much better to see those author names first. For example, imagine a long and drawn out thread that once was started by me; you have long read the older part of the thread and removed the inbox tag. Whenever a new email comes in on this thread, prior to this patch the author column in the search display will first show "Dirk Hohndel" - I think it should first show the actual author(s) of the new mail(s). Signed-off-by: Dirk Hohndel

lib: Audit calls to notmuch_message_get_header to handle NULL return

2010-04-24T13:50:04Z

Sebastian Spaeth reported [*] a segfault within libnotmuch when running notmuch operations while an asyncronous offlineimap job had removed some files from the mail store. Avoid this by handling all cases where notmuch_message_get_header could return NULL. [*] See message id:87d3xqti3o.fsf@SSpaeth.de on notmuch@notmuchmail.org

lib: Simplify code to set subject from matched message.

2010-04-24T13:50:04Z

Simply moving the code from _add_matched_message to a new _set_subject_from_message function.

Revert "thread: Simplify code for assigning the subject."

2010-04-22T21:01:41Z

This reverts commit 36e4459a328b8449b3e9d510be81a332a9b35aaa. With the two previous reverts, this fixes the recent message-sorting regression, so the test suite now passes again.

Revert "thread: Fix sort of search when constructing threads."

2010-04-22T21:00:33Z

This reverts commit f43990ce134d838cdb2cdd5d0752a602e81cfdd9.