notmuch/lib, branch 0.16_rc1

lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2013-06-25T05:53:16Z

Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can cover all four values of search --exclude in the cli. Previously the way to avoid any message being marked excluded was to pass in an empty list of excluded tags: since we now have an explicit option we might as well honour it. The enum is in a slightly strange order as the existing FALSE/TRUE options correspond to the new NOTMUCH_EXCLUDE_FLAG/NOTMUCH_EXCLUDE_TRUE options so this means we do not need to bump the version number. Indeed, an example of this is that the cli count and show still use FALSE/TRUE and still work.

cli: Guard deprecated g_type_init calls

2013-06-08T23:42:33Z

g_type_init was deprecated in GLib 2.35.1. In order to compile cleanly, guard these with a suitable #if. (commit msg from https://bugs.freedesktop.org/attachment.cgi?id=73774 )

lib: add --exclude=all option

2013-05-14T00:32:03Z

Adds a exclude all option to the lib which means that excluded messages are completely ignored (as if they had actually been deleted).

lib/database.cc: change how the parent of a message is calculated

2013-05-14T00:29:13Z

Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To header, such as the email address of the sender of the parent. This can fool notmuch. The updated algorithm prefers the last Message ID in the References header. The References header lists messages oldest-first, so the last Message ID is the parent (RFC2822, p. 24). The References header is also less likely to be in a non-standard syntax (http://cr.yp.to/immhf/thread.html, http://www.jwz.org/doc/threading.html). In case the References header is not to be found, fall back to the old behavior. V2 of this patch, incorporating feedback from Jani and (indirectly) Austin.

lib/message.cc: stale pointer bug (v3)

2013-05-04T00:17:56Z

Xapian::TermIterator::operator* returns std::string which is destroyed as soon as (*i).c_str() finishes. The remembered pointer 'term' then references invalid memory. Signed-off-by: Vladimir Marek

lib: Fix name reordering to handle commas without spaces

2013-03-29T13:24:29Z

Notmuch automatically re-orders names of the format "Last, First" to "First Last" when the associated email address is First.Last@example.com. But, if a name is of the format "Last,First" then notmuch will format the name as "irst Last". Handle any number of spaces after the comma, including none.

lib: Add an iterator over all messages in a thread

2013-02-19T00:20:59Z

Previously, getting the list of all messages in a thread required recursively traversing the thread's message hierarchy, which was both difficult and resulted in messages being out of order. This adds a public function to retrieve an iterator over all of the messages in a thread in oldest-first order.

lib: Eliminate _notmuch_message_list_append

2013-02-19T00:20:38Z

This API invited micro-optimized and complicated list pointer manipulation and is no longer used.

lib: Separate list of all messages from top-level messages

2013-02-19T00:20:24Z

Previously, thread.cc built up a list of all messages, then proceeded to tear it apart to transform it into a list of top-level messages. Now we simply build a new list of top-level messages. This simplifies the interface to _notmuch_message_add_reply, eliminates the pointer acrobatics from _resolve_thread_relationships, and will enable us to do things with the list of all messages in the following patches.

lib: Clean up error handling in _notmuch_thread_create

2013-02-19T00:20:09Z

Previously, there were various opportunities for memory leaks in the error-handling paths of this function. Use a local talloc context and some reparenting to make eliminate these leaks, while keeping the control flow simple.