notmuch/lib, branch 0.17_rc1 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.17_rc1 2013-11-20T00:15:02Z compact: improve error messages on failures after compaction 2013-11-20T00:15:02Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:27Z urn:sha1:2fd7ef64baf02892a7bebfb57d593afb086145ef The error messages written during the steps replacing old database with new now includes relevant paths and strerror. compact: unconditionally remove old wip database compact directory 2013-11-20T00:14:28Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:26Z urn:sha1:6452ae0fcb0a2ee45a47144da71a6de9d8dace2c In case previous notmuch compact has been interrupted there is old work-in-progress database compact directory partially filled. Remove it just before starting to fill the directory with new files. compact: preserve backup database until compacted database is in place 2013-11-20T00:13:25Z Tomi Ollila tomi.ollila@iki.fi 2013-11-14T22:03:25Z urn:sha1:cb6cc296e27fdab85faa4bdd670eda2e0c53b8c2 It is less error prone and window of failure opportunity is smaller if the old (backup) database is always renamed (instead of sometimes rmtree'd) before new (compacted) database is put into its place. Finally rmtree() old database in case old database backup is not kept. compact: catch Xapian::Error consistently 2013-11-18T00:25:43Z Tomi Ollila tomi.ollila@iki.fi 2013-11-13T17:02:44Z urn:sha1:19a89753ca20b269a131e747238925cce254c627 catch Xapian::Error in compact code in lib/database.cc to be consistent with other code in addition to not making software crash on uncaught other Xapian error. compact: tidy formatting 2013-11-18T00:25:25Z Tomi Ollila tomi.ollila@iki.fi 2013-11-13T17:02:43Z urn:sha1:4d5986e8ad671c1f5504894af6fbe37ba314bed8 Notmuch compact code whitespace changes to match devel/STYLE. lib: Document extent of some return values 2013-11-09T00:14:08Z Austin Clements amdragon@MIT.EDU 2013-10-24T15:19:03Z urn:sha1:215a8dc29c200bda1ecdbbbd44a57e2d32264ef1 This documents the extent of the notmuch_messages_t* pointers returned by notmuch_thread_get_toplevel_messages and notmuch_thread_get_messages. lib: add library version check macro 2013-11-07T23:15:06Z Jani Nikula jani@nikula.org 2013-11-06T19:01:41Z urn:sha1:060990db14bf3481c461959230549291a89e5c50 There have been some plans for making build incompatible changes to the library API. This is inconvenient, but it is much more so without a way to easily conditional build against multiple versions of notmuch. The macro has been lifted from glib. lib: use the compaction backup path provided by the caller 2013-11-07T10:51:16Z Jani Nikula jani@nikula.org 2013-11-03T12:24:47Z urn:sha1:00d2ac2b41a6dba060837244ee87edce2fd1e465 The extra path component added by the lib is a magic value that the caller just has to know. This is demonstrated by the current code, which indeed has "xapian.old" both sides of the interface. Use the backup path provided by the lib caller verbatim, without adding anything to it. lib: update documentation of callback functions for database_compact and database_upgrade. 2013-11-07T10:50:50Z David Bremner bremner@debian.org 2013-11-03T12:24:46Z urn:sha1:20abbe89a3014ff27978aea7be0cffbc715935ca Compact was missing callback documentation entirely, and upgrade did not discuss the closure parameter. lib: add closure parameter to compact status update callback 2013-11-07T10:46:42Z Jani Nikula jani@nikula.org 2013-11-03T12:24:45Z urn:sha1:180dba66e47a5257b2cdf2f1ceb59cc8fa5a69d4 This provides much more flexibility for the caller.