thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.19_rc2 2014-11-05T23:10:03Z 2014-11-05T23:10:03Z David Bremner david@tethera.net 2014-11-05T23:10:03Z urn:sha1:74bd4ea2ed8b5dc45643273c1fcc5797af47157a This should have been done at the same time as the SONAME bump. 2014-10-25T17:46:19Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:41Z urn:sha1:70f15b37fb226160acea591632b73ebe1e48809c Previously, it was necessary to link new messages to children to work around some (though not all) problems with the old metadata-based approach to stored thread IDs. With ghost messages, this is no longer necessary, so don't bother with child linking when ghost messages are in use. 2014-10-25T17:31:27Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:39Z urn:sha1:ee476f1e7616fa53c492b8077b55af35662eec82 This fixes the broken thread order test. 2014-10-25T17:30:08Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:38Z urn:sha1:d1e8c80b7239705b05bfa3e129c5de1c7099498a Somehow this is the first upgrade pass that actually does *any* error checking, so this also adds the bit of necessary infrastructure to handle that. 2014-10-25T17:27:07Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:37Z urn:sha1:58a4277d3b2ad88bc285f2dae998626b0aa73299 This updates the thread linking code to use ghost messages instead of user metadata to link messages into threads. In contrast with the old approach, this is actually correct. Previously, thread merging updated only the thread IDs of message documents, not thread IDs stored in user metadata. As originally diagnosed by Mark Walters [1] and as demonstrated by the broken T260-thread-order test, this can cause notmuch to fail to link messages even though they're in the same thread. In principle the old approach could have been fixed by updating the user metadata thread IDs as well, but these are not indexed and hence this would have required a full scan of all stored thread IDs. Ghost messages solve this problem naturally by reusing the exact same thread ID and message ID representation and indexing as regular messages. Furthermore, thanks to this greater symmetry, ghost messages are also algorithmically simpler. We continue to support the old user metadata format, so this patch can't delete any code, but when we do remove support for the old format, several functions can simply be deleted. [1] id:8738h7kv2q.fsf@qmul.ac.uk 2014-10-25T17:26:54Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:36Z urn:sha1:bc9c50602d20ce712188ea2cc3c5d30647d4d3f5 This updates the message abstraction to support ghost messages: it adds a message flag that distinguishes regular messages from ghost messages, and an internal function for initializing a newly created (blank) message as a ghost message. 2014-10-25T17:26:43Z Austin Clements aclements@csail.mit.edu 2014-10-24T12:49:15Z urn:sha1:d99491f27440d83f937131a861ca547bffb8bdf1 These macros help clarify basic bit-twiddling code and are written to be robust against C undefined behavior of shift operators. 2014-10-25T17:26:03Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:34Z urn:sha1:d9f5da00bb7707f3244654b4e44df2284e3634be This describes the structure of ghost mail documents. Ghost messages are not yet implemented. 2014-10-25T17:25:54Z Austin Clements amdragon@mit.edu 2014-10-23T12:30:33Z urn:sha1:1cdb96d3c4a2fc5ddf3a6e5c73c59c0f0e65cae2 This will be implemented over the next several patches. The feature is not yet "enabled" (this does not add it to NOTMUCH_FEATURES_CURRENT). 2014-10-11T05:10:12Z Austin Clements amdragon@mit.edu 2014-10-06T23:17:09Z urn:sha1:7487e2e2214b27407e542df164a4d23520bbd8d8 In the interest of robustness, avoid undefined behavior of sortable_unserialise if the date value is missing. This shouldn't happen now, but ghost messages will have blank date values.