notmuch/lib, branch 0.2

lib: search_threads: Fix nested search to handle original search of "*"

2010-04-15T21:54:40Z

When constructing a thread, we usually run a nested query to find all messages in the thread that match the original search string. However, we need to have special-case handling of an original search string of "*" now that that is a supported means of specifying all messages. The special-case ends up bein quite simple---we do less work, (just skipping the nested search since we know that all messages must match). I had been wanting to write this identical code to more efficiently handle "notmuch search thread:" which was previously running two identical searches. So that case is now more efficient as well.

Makefile: Add library version information on OS X.

2010-04-14T23:18:19Z

This encodes the library version into the library, where the linking binary can pick it up, and the linker can even enforce mismatches in the minor release, (such as linking a binary against version 1.2 and then attempting to run it against version 1.1).

Makefile: Fix library linking command for OS X

2010-04-14T23:16:05Z

I'm not sure which system Aaron used, but on the machine I have access to, (Darwin 8.11.0), the -shared and -dylib_install_name options are not recognized. Instead I use -dynamic_lib and -install_name as documented here: http://www.finkproject.org/doc/porting/shared.php

Add infrastructure for building shared library on OS X.

2010-04-14T23:10:27Z

This patch adds a configure check for OS X (actually Darwin), and sets up the Makefiles to build a proper shared library on that platform. Signed-off-by: Aaron Ecay

Makefile: Move compat sources from the client code to the library.

2010-04-14T23:03:18Z

Since the library code needs these as well.

Do not segfault on empty mime parts

2010-04-13T15:49:06Z

notmuch previously unconditionally checked mime parts for various properties, but not for NULL, which is the case if libgmime encounters an empty mime part. Upon encounter of an empty mime part, the following is printed to stderr (the second line due to my patch): (process:17197): gmime-CRITICAL **: g_mime_message_get_mime_part: assertion `GMIME_IS_MESSAGE (message)' failed Warning: Not indexing empty mime part. This is probably a bug that should get addressed in libgmime, but for not, my patch is an acceptable workaround. Signed-off-by: martin f. krafft

Fix typo in notmuch.h documentation regarding database open modes

2010-04-13T15:39:10Z

Reviewed-by: Carl Worth : The original proposal for having different open modes used the name WRITABLE. I didn't like that name, (easy to misspell as WRITEABLE even for native English speakers). So we renamed it to READ_WRITE immediately, but apparently some of the documentation held the old name for a while.

lib: Remove condition regarding a NULL parent_thread_id.

2010-04-12T22:54:03Z

A recent change guaranteed that a message ID can never be resolved to a NULL thread ID, so we don't need this extra case.

lib: Always add reference terms to the database.

2010-04-12T22:45:40Z

Previously, we were only adding the reference terms for cases where the referenced message did not yet exist in the database. For thread presentation, it's useful to have the connection information provided by the references, even when the messages are present. So add this term unconditionally.

lib: Document the metadata stored within the Xapian database.

2010-04-12T22:15:14Z

We are currently storing "version", "last_thread_id", and "thread_id_*" values so document how each of these are used.