notmuch/lib, branch 0.22.1_rc0

lib: fix definition of LIBNOTMUCH_CHECK_VERSION

2016-06-30T15:49:29Z

Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org Although the C99 standard 6.10 is a little non-obvious on this point, the docs for e.g. gcc are unambiguous. And indeed in practice with the extra space, this code fails #include #define foo (x) (x+1) int main(int argc, char **argv){ printf("%d\n",foo(1)); }

doc: forbid further operations on a closed database

2016-06-30T15:48:23Z

We could add many null pointer checks, but currently I don't see a use case that justifies it.

complete ghost-on-removal-when-shared-thread-exists

2016-04-15T10:13:49Z

To fully complete the ghost-on-removal-when-shared-thread-exists proposal, we need to clear all ghost messages when the last active message is removed from a thread. Amended by db: Remove the last test of T530, as it no longer makes sense if we are garbage collecting ghost messages.

On deletion, replace with ghost when other active messages in thread

2016-04-15T10:07:23Z

There is no need to add a ghost message upon deletion if there are no other active messages in the thread. Also, if the message being deleted was a ghost already, we can just go ahead and delete it.

Introduce _notmuch_message_has_term()

2016-04-15T10:07:23Z

It can be useful to easily tell if a given message has a given term associated with it.

Add internal functions to search for alternate doc types

2016-04-15T10:07:23Z

Publicly we are only exposing the non-ghost documents (of "type" "mail"). But internally we might want to inspect the ghost messages as well. This changeset adds two new private interfaces to queries to recover information about alternate document types.

fix thread breakage via ghost-on-removal

2016-04-15T10:07:23Z

implement ghost-on-removal, the solution to T590-thread-breakage.sh that just adds a ghost message after removing each message. It leaks information about whether we've ever seen a given message id, but it's a fairly simple implementation. Note that _resolve_message_id_to_thread_id already introduces new message_ids to the database, so i think just searching for a given message ID may introduce the same metadata leakage.

lib: clean up _notmuch_database_split_path

2016-04-12T23:46:42Z

Make the logic it a bit easier to read. No functional changes.

lib: fix handling of one character long directory names at top level

2016-04-12T23:40:19Z

The code to skip multiple slashes in _notmuch_database_split_path() skips back one character too much. This is compensated by a +1 in the length parameter to the strndup() call. Mostly this works fine, but if the path is to a file under a top level directory with one character long name, the directory part is mistaken to be part of the file name (slash == path in code). The returned directory name will be the empty string and the basename will be the full path, breaking the indexing logic in notmuch new. Fix the multiple slash skipping to keep the slash variable pointing at the last slash, and adjust strndup() accordingly. The bug was introduced in commit e890b0cf4011fd9fd77ebd87343379e4a778888b Author: Carl Worth Date: Sat Dec 19 13:20:26 2009 -0800 database: Store the parent ID for each directory document. just a little over two months after the initial commit in the Notmuch code history, making this the longest living bug in Notmuch to date.

lib: NOTMUCH_DEPRECATED macro also for older compilers

2016-03-14T22:54:32Z

Some compilers (older than gcc 4.5 and clang 2.9) do support __attribute__ ((deprecated)) but not __attribute__ ((deprecated("message"))). Check if clang version is at least 3.0, or gcc version is at least 4.5 to define NOTMUCH_DEPRECATED as the latter variant above. Otherwise define NOTMUCH_DEPRECATED as the former variant above. For a bit simpler implementation clang 2.9 is not included to use the newer variant. It is just one release, and the older one works fine. Clang 3.0 was released around 2011-11 and gcc 5.1 2015-04-22 (therefore newer macro for gcc 4.5+)