notmuch/lib, branch 0.34.3thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.34.32021-12-29T18:11:21Zlib/open: do not consider .notmuch alone as an existing database.2021-12-29T18:11:21ZDavid Bremnerdavid@tethera.net2021-12-25T21:22:56Zurn:sha1:25e0f5e59293ce961549201fdc74f81a3cc1675c
It makes perfect sense for users to want to pre-create .notmuch,
e.g. to install hooks, so we should handle the case of a .notmuch
directory without an actual xapian database more gracefully.
lib/config: don't overwrite database.path if the caller passed it2021-12-04T00:52:11ZDavid Bremnerdavid@tethera.net2021-10-28T01:34:19Zurn:sha1:59aac9cef37a9937bdf2265078d063673111f80b
If the user passed a path, and we opened it, then we consider that
definitive definition of "database.path". This makes libnotmuch
respond more gracefully to certain erroneous combinations of
NOTMUCH_CONFIG settings and config file contents.
lib/open: track which parameters are passed2021-12-04T00:50:03ZDavid Bremnerdavid@tethera.net2021-10-28T01:34:18Zurn:sha1:d467444085d96229172ce29ef8654c3c459b6ce2
This will be used to fine tune the loading of configuration for
certain special configuration items (initially just "database.path").
lib/load_config: deallocate / NULL database on fatal error2021-10-30T16:51:50ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:38Zurn:sha1:fe51c275fcd7107d92b40de511086300ba4060ed
This fixes a potential memory leak, and makes the behaviour of
notmuch_database_load_config (somewhat) consistent with
n_d_{open,create} with config.
lib/load_config: document expectations for db on error, add tests2021-10-30T16:49:37ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:37Zurn:sha1:8f0b84789d4fda0182e073b68b73160c9b94a4b7
This is a bit different than n_d_{open,create}_with_config, since
there are several non-zero status codes where we do want to return a
non-NULL database structure.
lib/create: fix memory leak, ensure *database=NULL on error2021-10-30T16:47:47ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:36Zurn:sha1:2ba50b52302dce08068843e0029f9ee935a0d7f3
This code previously relied on _finish_open to free the notmuch struct
on errors (except for the case of database == NULL, which was a
potential double free). When we removed those frees from _finish_open,
we introduced a (small) memory leak.
In this commit, fix the memory leak, and harmonize the on-error
behaviour with n_d_open_with_config.
lib/create: document expectations for db on error, add tests2021-10-30T16:45:40ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:35Zurn:sha1:f3fcdd2ddac2384c0c1daeffa495ad3ec01bc1af
It seems sensible to harmonize the behaviour with
n_d_open_with_config. In this commit we just assert the desired
behaviour.
lib/open: fix potential double-free, ensure *database=NULL on error2021-10-30T16:43:58ZDavid Bremnerdavid@tethera.net2021-10-23T13:22:34Zurn:sha1:74c4ce6d88bcc643424c5d89cc8d30cd835e46c3
During refactoring for 0.32, the code that set notmuch=NULL on various
errors was moved into _finish_open. This meant that the the code which
relied on that to set *database to NULL on error was no longer
correct. It also introduced a potential double free, since the notmuch
struct was deallocated inside _finish_open (via n_d_destroy).
In this commit we revert to "allocator frees", and leave any cleanup
to the caller of _finish_open. This allows us to get back the
behaviour of setting *database to NULL with a small change. Other
callers of _finish_open will need free notmuch on errors.
lib: document n_o_w_config can return NOTMUCH_STATUS_NO_CONFIG2021-10-30T16:41:57ZDavid Bremnerdavid@tethera.net2021-10-21T14:42:36Zurn:sha1:fb02817943e8cd646641d7f1fe914ce8adb3ecb2
This should be treated as fatal by callers, since we didn't succeed in
opening a Xapian database.
lib: bump lib minor version to 52021-10-15T11:34:39ZDavid Bremnerdavid@tethera.net2021-10-15T11:34:39Zurn:sha1:8383b6cb3a06146a2d3cf589090da10b5f78cde0
One new function (and an enum) was added to the API/ABI.