notmuch/lib, branch 0.4

lib: Eliminate some redundant includes of xapian.h

2010-11-02T06:24:40Z

Most files including this already include database-private.h which includes xapian.h already.

lib: Add GCC visibility(hidden) pragmas to private header files.

2010-11-02T05:35:48Z

This prevents any of the private functions from being leaked out through the library interface (at least when compiling with a recent-enough gcc to support the visibility pragma).

lib: Add some missing static qualifiers.

2010-11-02T04:58:43Z

These various functions and data are all used only locally, so should be marked static. Ensuring we get these right will avoid us accidentally leaking unintended symbols through the library interface.

Update library version to 1.2.0

2010-11-01T23:13:44Z

This increment is for the recently-added functions: notmuch_query_get_query_string notmuch_query_get_sort These were recently added to the library interface, but the library version was not incremented at that time, (shame on me).

Do not call ldconfig when building Debian package

2010-10-28T20:06:46Z

Hi, If I want to build Debian package, it fails with the following message: ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied make[1]: *** [install-lib] Error 1 The reason is that I build the package as a non-root user and make install invokes ldconfig unconditionally. The following patch contains a workaround, but I think that a more correct solution would be to check the condition LIBDIR_IN_LDCONFIG directly when make install is invoked rather than in configure as it is done now. Signed-off-by: Michal Sojka

lib: Add two functions: notmuch_query_get_query_string and _get_sort

2010-10-28T17:30:26Z

It can be handy to be able to query these settings from an existing query object.

lib: Fix notmuch_query_search_threads to return NULL on any Xapian exception.

2010-10-23T00:56:58Z

Previously, if the underlying search_messages hit an exception and returned NULL, this function would ignore that and return a non-NULL, (but empty) threads object. Fix this to properly propagate the error.

lib: Fix "make install"

2010-09-21T16:09:01Z

This has been broken since the addition of the test sub-directory to our non-recursive make system.

lib: Fix use-after-free bug.

2010-09-20T22:01:52Z

Thanks to the new git-based test suite, it's easy to run the whole test suite in valgrind, (simply "make test OPTIONS="--valgrind"), and doing so showed this obvious use-after-free bug, (triggered by the thread-order tests).

make install: Run ldconfig or install a DT_RUNPATH in binary as appropriate.

2010-06-04T23:52:56Z

Various users were confused as to why they couldn't run notmuch immediately after "make install", (with linker errors saying that libnotmuch.so could not be found). The errors came from two different causes: 1. The user had installed to a system library directory, but had not yet run ldconfig. 2. The user had installed to some non-system directory, and had not set the LD_LIBRARY_PATH variable. With this change we fix both problems (on Linux) without the user having to do anything additional. We first use ldconfig to find the system library directories. If the user is installing to one of these, then we run ldconfig as part of "make install". For case (2) we use the -rpath and --enable-new-dtags linker options to install a DT_RUNPATH entry in the binary. This entry tells the dynamic linker where to find libnotmuch. Without the --enable-new-dtags option only a DT_RPATH option would be installed, (which has the drawback of not allowing any override with the LD_LIBRARY_PATH variable). Distributions (such as Debian and Fedora) don't want to see binaries packaged with a DT_RPATH or DT_RUNPATH entry. This should be avoided automatically as long as the packages install to standard locations, (such as /usr/lib).