notmuch/lib, branch 0.5 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.5 2010-11-12T04:54:41Z lib: Fix missing initialization of status field. 2010-11-12T04:54:41Z Carl Worth cworth@cworth.org 2010-11-12T04:54:41Z urn:sha1:7278383005de3a0d61ac3471162e7ef633d45076 This could have been a problematic bug. Fortuinately "gcc -O2" warns about it. lib: Add two missing static qualifiers 2010-11-12T04:53:21Z Carl Worth cworth@cworth.org 2010-11-12T04:53:21Z urn:sha1:fe8eeaf4a576b4cad2ec4faee8d5e373118771f8 The debian packaging is nice enough to notice when we accidentally leak private symbols to the public interface. Increment library version to 1.3.0 2010-11-12T04:42:45Z Carl Worth cworth@cworth.org 2010-11-12T04:42:45Z urn:sha1:d33dee5389e5d4a88c8504b1c94d2c9cb432fe52 For the addition of three functions: notmuch_message_get_filenames notmuch_message_tags_to_maildir_flags notmuch_message_maildir_flags_to_tags tags_to_maildir_flags: Fix to preserve existing, unsupported flags 2010-11-12T00:36:02Z Carl Worth cworth@cworth.org 2010-11-12T00:36:02Z urn:sha1:96d99c383785dec67443ff1b45e2d2f8437398fa This is to prevent notmuch from destroying any information the user has encoded as flags in the maildir filename. Tests are also added to the test suite to verify the documented behavior. notmuch_message_tags_to_maildir_flags: Do nothing outside of "new" and "cur" 2010-11-11T22:32:17Z Carl Worth cworth@cworth.org 2010-11-11T22:32:17Z urn:sha1:95dd5fe5d7e9cd8169a6e3174ea27376acd92870 Some people use notmuch with non-maildir files, (for example, email messages in MH format, or else cool things like using sluk[*] to suck down feeds into a format that notmuch can index). To better support uses like that, don't do any renaming for files that are not in a directory named either "new" or "cur". [*] https://github.com/krl/sluk/ lib: Be honest in the documentation of the maildir functions 2010-11-11T12:51:55Z Carl Worth cworth@cworth.org 2010-11-11T12:51:55Z urn:sha1:1ea0b8bfe164a0f7a3e750236b8aef9b5ab8917e I had originally hoped for better semantics, such as doing nothing in non-maildir directories, and preserving unknown maildir flags that happen to be present. We could still do those things, of course, but for now, remove them from the documentation since the implementation does not do these things yet. notmuch_message_tags_to_maildir_flags: Don't exit on failure to rename. 2010-11-11T11:50:42Z Carl Worth cworth@cworth.org 2010-11-11T11:50:42Z urn:sha1:37a8096fdc0584567aab43a8bede7b32860a3517 It is totally legitimate for a non-maildir directory to be named "new" (and not have a directory next to it named "cur"). To support this case at least, be silent about any rename failure. notmuch_message_tags_to_maildir_flags: Fix to rename multiple files 2010-11-11T11:47:11Z Carl Worth cworth@cworth.org 2010-11-11T11:41:39Z urn:sha1:71a3201885d508f10ecd24a0887337e1624ffbf1 This function was documented as modifying every filename associated with the message. Fix it to actually do that. notmuch_filenames_create: Take a reference to underlying filename list 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T11:36:13Z urn:sha1:8480a0a00370f997a29ebf98560a799ece43d3f4 The notmuch_filenames_t object might easily outlive the original object owning the filename list. So take a talloc reference to keep things safe. maildir_flags_to_tags: Avoid interpreting "no info" as "no flags set". 2010-11-11T11:40:19Z Carl Worth cworth@cworth.org 2010-11-11T10:55:13Z urn:sha1:404db1de90f6e5a66c34077b38b18a39c955ece2 If a filename has no maildir info at all, (that is, it does not contain the sequence ":2,"), we consider this distinct from a filename with an empty maildir info, (the ":2," separator is present, but no flags characters follow). Specifically, we regard a missing info field as providing no information, so tags will remain unchanged. On the other hand, an info field that is present but has no flags set will cause various tags to be cleared, (or in the case of "unread", added). This fixes the "remove info" case of the maildir-sync tests in the test suite.