notmuch/lib, branch debian/0.28-2thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.28-22018-09-06T11:07:13Zlib: change parent strategy to use In-Reply-To if it looks sane2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:15Zurn:sha1:87934c432c4bee9df09f268a3f05933c59c2caf1
As reported by Sean Whitton, there are mailers (in particular the
Debian Bug Tracking System) that have sensible In-Reply-To headers,
but un-useful-for-notmuch References (in particular with the BTS, the
oldest reference is last). I looked at a sample of about 200K
messages, and only about 0.5% these had something other than a single
message-id in In-Reply-To. On this basis, if we see a single
message-id in In-Reply-To, consider that as authoritative.
lib: add _notmuch_message_id_parse_strict2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:14Zurn:sha1:b31e44c678bf3bfe81bcc5f159e627551f12700f
The idea is that if a message-id parses with this function, the MUA
generating it was probably sane, and in particular it's probably safe
to use the result as a parent from In-Reply-to.
lib/thread: change _resolve_thread_relationships to use depths2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:10Zurn:sha1:46dce33abc82ea6ebd3be2e0887506af4185c739
We (finally) implement the XXX comment. It requires a bit of care not
to reparent all of the possible toplevel messages.
_notmuch_messages_has_next is not ready to be a public function yet,
since it punts on the mset case. We know in the one case it is called,
the notmuch_messages_t is just a regular list / iterator.
lib/thread: rewrite _parent_or_toplevel to use depths2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:09Zurn:sha1:21803df6aeb20ff2e91068988441f10fc4b6853a
This is part 1/2 of changing the reparenting of alleged toplevel
messages to use a "deep" reference rather than just the first one
found.
lib: calculate message depth in thread2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:08Zurn:sha1:0a7181dd163babefaefa9988ed51dc66c892eb3e
This will be used in reparenting messages without useful in-reply-to,
but with useful references
lib/thread: initial use of references as for fallback parenting2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:07Zurn:sha1:a33085828408ec421bcfcf23449b51e0a0e3cece
This is mainly to lay out the structure of the final code. The problem
isn't really solved yet, although some very simple cases are
better (hence the fixed test). We need two passes through the messages
because we need to be careful not to re-parent too many messages and
end up without any toplevel messages.
use EMPTY_STRING in _parent_via_in_reply_to2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-09-03T15:26:10Zurn:sha1:ac2146118b83ca08aa6dd1275f65eefaed9fe2c0
This is a review suggestion [1] of Tomi. I decided not to squash it
so that the code movement remains clear.
[1]: id:m2pnxxgf5q.fsf@guru.guru-group.fi
lib/thread: refactor in_reply_to test2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-08-30T11:29:06Zurn:sha1:b9d4eb04126c3ac4e7287443de7eae7290cd5273
This is not a complete win in code-size, but it makes the code (which
is about to get more complicated) easier to follow.
lib: add _notmuch_message_list_empty2018-09-06T11:07:13ZDavid Bremnerdavid@tethera.net2018-09-03T21:02:25Zurn:sha1:dc3cc18bf0c649dfdb280a7afbb3b6039101f281
There is no public notmuch_message_list_t public interface, so to this
is added to the private API. We use it immediately in thread.cc;
future commits will use it further.
lib/thread: add macro for debug printing of threading2018-09-06T11:07:12ZDavid Bremnerdavid@tethera.net2018-09-03T14:00:26Zurn:sha1:040fd630bf74eb8be75633bf3cbdb0c38d0f16f2
This is analogous to DEBUG_DATABASE_SANITY, and is intended to help
debugging and to help users submit bug reports.