notmuch/lib, branch debian/0.29.2-2

indexing: record protected subject when indexing cleartext

2019-05-29T11:14:44Z

When indexing the cleartext of an encrypted message, record any protected subject in the database, which should make it findable and visible in search. Signed-off-by: Daniel Kahn Gillmor

lib/database: index user headers.

2019-05-25T10:21:13Z

This essentially involves calling _notmuch_message_gen_terms once for each user defined header.

lib: support user prefix names in term generation

2019-05-25T10:17:27Z

This should not change the indexing process yet as nothing calls _notmuch_message_gen_terms with a user prefix name. On the other hand, it should not break anything either. _notmuch_database_prefix does a linear walk of the list of (built-in) prefixes, followed by a logarithmic time search of the list of user prefixes. The latter is probably not really noticable.

lib: cache user prefixes in database object

2019-05-25T10:08:20Z

This will be used to avoid needing a database access to resolve a db prefix from the corresponding UI prefix (e.g. when indexing). Arguably the setup of the separate header map does not belong here, since it is about indexing rather than querying, but we currently don't have any other indexing setup to do.

lib: setup user headers in query parser

2019-05-25T09:56:16Z

These tests will need to be updated if the Xapian query print/debug format changes.

n_m_remove_indexed_terms: reduce number of Xapian API calls.

2019-05-23T11:00:56Z

Previously this functioned scanned every term attached to a given Xapian document. It turns out we know how to read only the terms we need to preserve (and we might have already done so). This commit replaces many calls to Xapian::Document::remove_term with one call to ::clear_terms, and a (typically much smaller) number of calls to ::add_term. Roughly speaking this is based on the assumption that most messages have more text than they have tags. According to the performance test suite, this yields a roughly 40% speedup on "notmuch reindex '*'"

lib/message-file: close stream in destructor

2019-05-10T15:26:50Z

Without this, $ make time-test OPTIONS=--small leads to fatal errors from too many open files. Thanks to st-gourichon-fid for bringing this problem to my attention in IRC.

lib/message_file: open gzipped files

2019-05-03T10:48:43Z

Rather than storing the lower level stdio FILE object, we store a GMime stream. This allows both transparent decompression, and passing the stream into GMime for parsing. As a side effect, we can let GMime close the underlying OS stream (indeed, that stream isn't visible here anymore). This change is enough to get notmuch-{new,search} working, but there is still some work required for notmuch-show, to be done in a following commit.

gmime-cleanup: pass NULL as default GMimeParserOptions

2019-05-03T09:58:00Z

This is a functional change, not a straight translation, because we are no longer directly invoking g_mime_parser_options_get_default(), but the GMime source has indicated that the options parameter for g_mime_parser_construct_message() is "nullable" since upstream commit d0ebdd2ea3e6fa635a2a551c846e9bc8b6040353 (which itself precedes GMime 3.0). Signed-off-by: Daniel Kahn Gillmor

gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it

2019-05-03T09:57:27Z

Several GMime 2.6 functions sprouted a change in the argument order in GMime 3.0. We had a compatibility layer here to be able to handle compiling against both GMime 2.6 and 3.0. Now that we're using 3.0 only, rip out the compatibility layer for those functions with changed argument lists, and explicitly use the 3.0 argument lists. Signed-off-by: Daniel Kahn Gillmor