notmuch/lib, branch debian/0.32-1

lib/config: remove early free in _get_email_from_passwd_file

2021-04-24T15:11:45Z

This (obvious) bug was caused by cut&pasting the code from notmuch-config.c into the library and adding on a return at the end.

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

lib/n_d_index_file: check return value from _n_m_add_filename

2021-04-18T13:02:20Z

Ignoring this return value seems like a bad idea in general, and in particular it has been hiding one or more bugs related to handling long directory names.

lib: directly traverse postlists in _n_message_delete

2021-04-18T12:50:36Z

This is intended to fix the slow behaviour of "notmuch new" (and possibly "notmuch reindex") when large numbers of files are deleted. The underlying issue [1] seems to be the Xapian glass backend spending a large amount of time in db.has_positions when running queries with large-ish amounts of unflushed changes. This commit removes two uses of Xapian queries [2], and replaces them with an approximation of what Xapian would do after optimizing the queries. This avoids the calls to has_positions (which are in any case un-needed because we are only using boolean terms here). [1] Thanks to "andres" on IRC for narrowing down the performance bottleneck. [2] Thanks to Olly Betts of Xapian fame for talking me a through a fix that does not require people to update Xapian.

lib: provide notmuch_config_path

2021-03-27T12:26:14Z

Since the library searches in several locations for a config file, the caller does not know which of these is chosen in the usual case of passing NULL as a config file. This changes provides an API for the caller to retrieve the name of the config file chosen. It will be tested in a following commit.

CLI+lib: detect missing database in split configurations.

2021-03-27T12:26:14Z

Eventually we want to do all opening of databases in the top level (main function). This means that detection of missing databases needs to move out of subcommands. It also requires updating the library to use the new NO_DATABASE status code.

lib: add NOTMUCH_STATUS_NO_DATABASE

2021-03-27T12:26:14Z

This will allow more precise return values from various open related functions.

CLI/config: migrate notmuch_config_open to new config

2021-03-27T12:26:14Z

notmuch_config_open will be preserved in the medium term for use by the commands that are manipulating the config file directly (config and setup)

lib/open: canonicalize relative path read from config file

2021-03-27T12:26:14Z

This matches functionality in the the CLI function notmuch_config_get_database_path, which was previously used in the CLI code for all calls to open a database.

lib/config: set default for primary user email

2021-03-27T12:26:14Z

This is mainly copying code from the CLI into the lib. The CLI copy will be deleted in a later commit.