notmuch/lib, branch debian/0.33-2

Merge tag 'debian/0.32.3-1'

2021-08-19T04:46:42Z

notmuch release 0.32.3-1 for unstable (sid) [dgit] [dgit distro=debian no-split --quilt=linear]

lib/open: look in MAILDIR for database, as documented.

2021-08-18T00:09:21Z

This fixes the bug id:87bl9lx864.fsf@kisara.moe

lib: bump libnotmuch minor version

2021-08-17T23:30:22Z

Notmuch 0.32 corresponds to libnotmuch 5.4 as indicated by docstrings; however, the minor number wasn't bumped. Any libnotmuch downstream consumer using the LIBNOTMUCH_CHECK_VERSION macro to support multiple versions won't be able to access the new 5.4 functions. Signed-off-by: Austin Ray

lib: correct deprecated db open functions' docs

2021-08-17T23:30:05Z

Both notmuch_database_open() and notmuch_database_open_verbose()'s documentation state they call notmuch_database_open_with_config() with config_path=NULL; however, their implementations pass an empty string. The empty string is the correct value to maintain their original behavior of not loading the user's configuration so their documentation is incorrect.

lib: update transaction documentation

2021-06-27T17:06:30Z

Partly this is to recognize the semantics we inherit from Xapian, partly to mention the new autocommit feature.

lib: autocommit after some number of completed transactions

2021-06-27T17:03:00Z

This change addresses two known issues with large sets of changes to the database. The first is that as reported by Steven Allen [1], notmuch commits are not "flushed" when they complete, which means that if there is an open transaction when the database closes (or e.g. the program crashes) then all changes since the last commit will be discarded (nothing is irrecoverably lost for "notmuch new", as the indexing process just restarts next time it is run). This does not really "fix" the issue reported in [1]; that seems rather difficult given how transactions work in Xapian. On the other hand, with the default settings, this should mean one only loses less than a minutes worth of work. The second issue is the occasionally reported "storm" of disk writes when notmuch finishes. I don't yet have a test for this, but I think committing as we go should reduce the amount of work when finalizing the database. [1]: id:20151025210215.GA3754@stebalien.com

lib/config: add NOTMUCH_CONFIG_AUTOCOMMIT

2021-06-27T16:59:42Z

This will be used to control how often atomic transactions are committed.

database/close: remove misleading code / comment

2021-06-27T16:58:17Z

Unfortunately, it doesn't make a difference if we call cancel_transaction or not, all uncommited changes are discarded if there is an open (unflushed) transaction.

lib/database: fix style mistake.

2021-06-27T16:52:43Z

The spacing of the declaration was wrong in ea30110.

Merge branch 'release'

2021-06-25T12:34:29Z