notmuch/lib, branch feature/git-remote

lib/config: add config keys for git-remote-notmuch.

2025-08-09T11:19:43Z

The precise function will be explained in a future update to notmuch-config(1).

lib: return NOTMUCH_STATUS_OPERATION_INVALIDATED where appropriate

2025-08-09T10:12:23Z

The overall goal is to allow clients to restart operations in situations where that is the response recommended by the underlying Xapian library. Amended-by: db, added above explanation

lib/database-private: undef XAPIAN_DEPRECATED before redefining it

2025-08-04T13:44:52Z

Silences compiler warnings about redefining a macro.

lib: add notmuch_threads_status()

2025-08-04T13:43:35Z

While a number of errors can happen when iterating over threads (DatabaseModifiedError, memory allocation errors, etc.), the API currently cannot signal them to the caller, and either triggers an internal error (aborting the caller) or returns NULL from notmuch_threads_get() with no information on what actually went wrong. Add a new public function notmuch_threads_status() - similar to previously added notmuch_messages_status() - that allows propagating those errors to the caller. Use this to remove the INTERNAL_ERROR() in _notmuch_thread_create() (triggered by T642). Fixes: https://github.com/pazz/alot/issues/1460 Amended-By: db. Resolved whitespace disagreement between emacs and uncrustify in favour of uncrustify.

lib/config: simplify cleanup in notmuch_database_get_config_list()

2025-08-04T13:15:38Z

The list destructor is always set when necessary (i.e. if the iterator is successfully created), so there is never a need to invoke it explicitly, even on failure.

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

config: allow custom separators in author lists

2024-07-26T06:59:11Z

Allow distinguishing between commas separating authors and separating first and last names. Amended by db: reformat NEWS entry and commit message. Tweaked whitespace in lib/thread.cc.

lib: thread-safe s-expression query parser

2024-07-25T10:15:02Z

Follow-up of 6273966d, now that sfsexp 1.4.1 doesn't rely on globals anymore by default (https://github.com/mjsottile/sfsexp/issues/21). This simply defers the initial query generation to use the thread-safe helper (xapian_query_match_all) instead of Xapian::Query::MatchAll.

lib: clear error message on success in _choose_database_path

2023-12-06T11:33:05Z

Previously we both found a database and returned a message saying that the database could not be found (along with a success code). This change should prevent spurious error output.

lib/string_map: simulate stable sorting

2023-11-28T13:19:21Z

qsort(3) does not promise stability, and recent versions of glibc have been showing more unstable behaviour [2]. Michael Gruber observed [1] test breakage due to changing output order for message properties. We provide a sorting order of (key,value) pairs that _looks_ stable by breaking ties based on value if keys are equal. Internally there may be some instability in the case of duplicate (key,value) pairs, but it should not be observable via the iterator API. [1]: id:CAA19uiSHjVFmwH0pMC7WwDYCOSzu3yqNbuYhu3ZMeNNRh313eA@mail.gmail.com [2]: id:87msv3i44u.fsf@oldenburg.str.redhat.com