notmuch/mime-node.c, branch 0.16_rc1

cli: mime node: fix compiler warning when building against gmime 2.4

2013-04-14T22:49:16Z

commit d487ef9e58bcd193118f19f771d5ef3984616be5 Author: Jani Nikula Date: Sat Mar 30 15:53:16 2013 +0200 cli: mime node: abstract decryption and signature verification introduced a compiler warning, reported by Mark Walters, when building against gmime 2.4: mime-node.c:224:9: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default] Pass the non-const signature validity to the destructor to fix this.

cli: mime node: abstract decryption and signature verification

2013-04-01T19:39:33Z

The code filled with #ifdef GMIME_ATLEAST_26 is difficult to read. Abstract the decryption and signature verification into functions, with separate implementations for GMime 2.4 and 2.6, to clarify the code. There should be no functional changes.

Avoid potentially dereferencing a NULL pointer

2012-09-27T15:52:34Z

GMIME_IS_MULTIPART and GMIME_IS_MESSAGE both handle NULL pointers gracefully, but the G_OBJECT_TYPE used in the error handling block dereferences it without checking it first. Fix this by checking whether parent->part is valid. Found using the clang static analyzer. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

cli: use new notmuch_crypto_get_context in mime-node.c

2012-06-10T23:09:42Z

This has the affect of lazily creating the crypto contexts only when needed. This removes code duplication from notmuch-show and notmuch-reply, and should speed up these functions considerably if the crypto flags are provided but the messages don't have any cryptographic parts.

cli: new crypto verify flag to handle verification

2012-06-10T23:09:09Z

Use this flag rather than depend on the existence of an initialized gpgctx, to determine whether we should verify a multipart/signed. We will be moving to create the ctx lazily, so we don't want to depend on it being previously initialized if it's not needed.

cli: modify mime_node_context to use the new crypto struct

2012-06-10T23:08:56Z

This simplifies some more interfaces.

cli: modify mime_node_open to take new crypto struct as argument

2012-06-10T23:06:48Z

This simplifies the interface considerably.

cli: use new typedef to deal with gmime 2.4/2.6 context incompatibility

2012-06-10T23:04:50Z

gmime 2.4 defines GMimeCipherContext, while 2.6 defines GMimeCryptoContext. typedef them both to notmuch_crypto_context_t to cover this discrepancy and remove a bunch of #ifdefs.

Handle errors in mime_node_open

2012-03-11T01:25:19Z

mime node: Record depth-first part numbers

2012-01-25T11:19:22Z

This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do.