notmuch/mime-node.c, branch 0.25.2

cli/crypto: fix segfault on failed gmime2 crypto context creation

2017-11-05T19:41:13Z

Commit 1fdc08d0ffab ("cli/crypto: treat failure to create a crypto context as fatal.") started treating crypto context creation failures "as fatal", returning NULL from _mime_node_create(). Unfortunately, we do not have NULL checks for _mime_node_create() failures. The only caller, mime_node_child(), could check and return NULL (as it's documented to do on errors) but none of the several call sites have NULL checks either. And none of them really have a trivial but feasible and graceful way of recovery. So while the right thing to do would be to handle NULL returns properly all over the place, and we have other scenarios that do return NULL from above mentioned functions, the crypto context creation failure is something that does seem to show up regularly in some scenarios, revert back to the functionality before commit 1fdc08d0ffab as an interim fix.

crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3

2017-07-16T00:43:08Z

gmime 3.0 knows how to select the correct GMimeCryptoContext automatically, so a bunch of the code in notmuch can be dropped in that case. The #ifdef removal of the crypto stuff is better than #define aliasing in gmime-extra.h for this stuff. When built against gmime 3.0: * it reduces compiled code, and * it avoids initializing unused gpgme contexts (based on a patch from dkg)

cli/crypto: eliminated compiler warnings about unused arguments

2017-07-16T00:42:49Z

These are due to (excessively?) fancy macro definitions in gmime-extra.h

cli/crypto: treat failure to create a crypto context as fatal.

2017-07-16T00:39:37Z

Silently ignoring signed/encrypted parts seems like the wrong idea, and it also complicates future gmime-3.0 compatibility changes.

cli: simplify mime node walk

2017-03-10T11:55:15Z

The function is more straighforward to read when it's clear that the only non-NULL return is at one place. No functional changes.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

cli/lib: remove support for GMime 2.4

2015-08-26T23:01:45Z

It's becoming a maintenance burden to do anything things with the crypto glue code twice, once for 2.4 and once for 2.6. I don't have any 2.4 version available to test on my development machine anymore, so the 2.4 specific code paths are likely not very well tested.

cli: mime node: fix compiler warning when building against gmime 2.4

2013-04-14T22:49:16Z

commit d487ef9e58bcd193118f19f771d5ef3984616be5 Author: Jani Nikula Date: Sat Mar 30 15:53:16 2013 +0200 cli: mime node: abstract decryption and signature verification introduced a compiler warning, reported by Mark Walters, when building against gmime 2.4: mime-node.c:224:9: warning: assignment discards ‘const’ qualifier from pointer target type [enabled by default] Pass the non-const signature validity to the destructor to fix this.

cli: mime node: abstract decryption and signature verification

2013-04-01T19:39:33Z

The code filled with #ifdef GMIME_ATLEAST_26 is difficult to read. Abstract the decryption and signature verification into functions, with separate implementations for GMime 2.4 and 2.6, to clarify the code. There should be no functional changes.

Avoid potentially dereferencing a NULL pointer

2012-09-27T15:52:34Z

GMIME_IS_MULTIPART and GMIME_IS_MESSAGE both handle NULL pointers gracefully, but the G_OBJECT_TYPE used in the error handling block dereferences it without checking it first. Fix this by checking whether parent->part is valid. Found using the clang static analyzer. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>