notmuch/notmuch-client.h, branch 0.26.2

crypto: new decryption policy "auto"

2017-12-08T12:07:53Z

This new automatic decryption policy should make it possible to decrypt messages that we have stashed session keys for, without incurring a call to the user's asymmetric keys.

lib: convert notmuch decryption policy to an enum

2017-12-08T12:07:02Z

Future patches in this series will introduce new policies; this merely readies the way for them. We also convert --try-decrypt to a keyword argument instead of a boolean.

indexopts: change _try_decrypt to _decrypt_policy

2017-12-08T12:06:03Z

This terminology makes it clearer what's going on at the API layer, and paves the way for future changesets that offer more nuanced decryption policy.

cli: set up shared command-line arguments for indexing

2017-10-21T22:58:11Z

We have an indexopts structure for manipulating indexing in different ways, but we also have three command-line invocations that can trigger indexing: new, insert, and reindex. This changeset prepares a common parser that these subcommands can share. Note: if the deprecated crypto.gpg_path configuration option is set to anything other than "gpg", we ignore it (and print a warning on stderr, if built against gmime < 3.0). At the moment, it's just --try-decrypt, but others will likely follow.

crypto: move into libnotmuch_util

2017-10-20T10:58:10Z

This prepares us for using the crypto object in both libnotmuch and the client.

crypto: _notmuch_crypto_cleanup should return void

2017-10-13T01:11:55Z

There's no chance that _notmuch_crypto_cleanup() will ever return anything other than 0, and no one ever checks its return value anyway. So make it return void instead of int.

crypto: drop pretense of notmuch_crypto_context_t

2017-10-13T01:11:33Z

notmuch_crypto_context_t was introduced (i think) as some sort of abstraction layer to make notmuch somewhat independent of GMime. But it isn't even useful for GMime 3.0 or later -- we can drop the pretense that it's some sort of abstraction in this case, and just call it what it is, GMimeCryptoContext, which is useful for building against older versions of GMime. This also renames _notmuch_crypto_get_context() to _notmuch_crypto_get_gmime_context().

crypto: rename notmuch_crypto_t to _notmuch_crypto_t

2017-10-13T01:11:25Z

The notmuch_crypto_t struct isn't used externally, and we have no plans to explicitly export it. Prefix its name (and associated functions) with _ to make that intent clear.

cli: convert notmuch_bool_t to stdbool

2017-10-10T01:24:02Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool.

cli: use designated initializers for opt desc

2017-10-05T01:00:42Z

Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output variables, where the output variable being non-NULL determines the type. Introduce checks to ensure only one is set. The downside is some waste of const space per argument; this could be saved by retaining opt_type and using a union, but that's still pretty verbose. - Fix some variables due to the type safety. Mostly a good thing, but leads to some enums being changed to ints. This is pedantically correct, but somewhat annoying. We could also cast, but that defeats the purpose a bit. - Terminate the opt desc arrays using {}. The output variable type safety and the ability to add new fields for just some output types or arguments are the big wins. For example, if we wanted to add a variable to set when the argument is present, we could do so for just the arguments that need it. Beauty is in the eye of the beholder, but I think this looks nice when defining the arguments, and reduces some of the verbosity we have there.