thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.38.2 2021-09-05T00:07:19Z 2021-09-05T00:07:19Z David Bremner david@tethera.net 2021-08-24T15:17:10Z urn:sha1:d447b694b498c3e18a22f1eb15139a798c6aab26 It turns out that now that we pass an open database into the subcommands, it is easy to check any requested uuid against the database at the same time as we process the other shared arguments. This results in overall less boilerplate code, as well as making a CLI scope function and variable file scope in notmuch.c. 2021-04-07T00:32:36Z David Bremner david@tethera.net 2021-02-27T14:07:45Z urn:sha1:1c747a501c0ed7df5eaa2b994b9ad11d8981c62c At this point it is unused in all subcommands. 2021-03-13T12:45:34Z uncrustify david@tethera.net 2021-03-13T12:45:34Z urn:sha1:eef21c284742fa5ae14d7d352acc3a4dc98821ce This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory Line breaks were then adjusted manually to keep argc and argv together. 2021-02-06T23:36:06Z David Bremner david@tethera.net 2020-12-24T03:45:23Z urn:sha1:f118ef3c3db0a01479a505ba85a34879d8e0dede Switch to the newly created API function notmuch_database_compact_db, which takes the database opened in main(). 2021-02-06T23:05:19Z David Bremner david@tethera.net 2020-12-21T12:55:14Z urn:sha1:319efe21c9d2754c99951cecc71184faf7ca9054 This will allow transitioning individual subcommands to the new configuration framework. Eventually when they are all converted we can remove the notmuch_config_t * argument. For now, live with the parameter shadowing in some some subcommands; it will go away when they are converted. 2017-10-10T01:24:02Z Jani Nikula jani@nikula.org 2017-10-07T08:44:04Z urn:sha1:0f314c0c99befea599a68bea51d759b4133efef6 C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool. 2017-10-05T01:00:42Z Jani Nikula jani@nikula.org 2017-10-01T20:53:11Z urn:sha1:4a6721970a42a9f86149fb5d395d1001fed2d305 Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output variables, where the output variable being non-NULL determines the type. Introduce checks to ensure only one is set. The downside is some waste of const space per argument; this could be saved by retaining opt_type and using a union, but that's still pretty verbose. - Fix some variables due to the type safety. Mostly a good thing, but leads to some enums being changed to ints. This is pedantically correct, but somewhat annoying. We could also cast, but that defeats the purpose a bit. - Terminate the opt desc arrays using {}. The output variable type safety and the ability to add new fields for just some output types or arguments are the big wins. For example, if we wanted to add a variable to set when the argument is present, we could do so for just the arguments that need it. Beauty is in the eye of the beholder, but I think this looks nice when defining the arguments, and reduces some of the verbosity we have there. 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2015-08-14T16:23:49Z David Bremner david@tethera.net 2015-04-05T22:39:55Z urn:sha1:f76d8f82dd004cf14426a91e8a80dcd2a4b97317 The function notmuch_exit_if_unmatched_db_uuid is split from notmuch_process_shared_options because it needs an open notmuch database. There are two exceptional cases in uuid handling. 1) notmuch config and notmuch setup don't currently open the database, so it doesn't make sense to check the UUID. 2) notmuch compact opens the database inside the library, so we either need to open the database just to check uuid, or change the API. 2015-06-01T05:32:54Z David Bremner david@tethera.net 2015-04-05T13:13:03Z urn:sha1:0018a8d787a98f80c665061daa9b0c73839d3666 Unfortunately it seems trickier to support --config globally The non-trivial changes are in notmuch.c; most of the other changes consists of blindly inserting two lines into every subcommand.