notmuch/notmuch-config.c, branch 0.18

compat: add canonicalize_file_name

2014-04-08T10:27:14Z

the POSIX 2008 behaviour of realpath is not available everywhere so we provide a simple wrapper function. We use (and provide) the gnu extension canonicalize_file_name to make it cleaner to test for the feature we need; otherwise we have to rely on realpath segfaulting if the second argument is null.

cli: abstract common config get/set code

2014-01-19T00:09:49Z

Pretty straightforward abstraction similar to get/set list.

cli: clean up exit status code returned by the cli commands

2014-01-18T18:45:26Z

Apart from the status codes for format mismatches, the non-zero exit status codes have been arbitrary. Make the cli consistently return either EXIT_SUCCESS or EXIT_FAILURE.

notmuch-config: use strchr(), not index() (Solaris support)

2013-08-24T09:37:51Z

notmuch-config.c has the only use of the function named "index()" in the notmuch source. Several other places use the equivalent function "strchr()"; this patch just fixes notmuch-config.c to use strchr() instead. (Solaris needs to include to get the prototype for index(), and notmuch-config.c was failing to include that header, so it wasn't compiling as-is.)

cli: config: fix config file save when the file does not exist

2013-05-12T10:46:44Z

The use of realpath(3) in commit 58ed67992d0ec1fa505026105218fa449f7980b0 Author: Jani Nikula Date: Sun Apr 7 20:15:03 2013 +0300 cli: config: do not overwrite symlinks when saving config file broke config file save when the file does not exist, which results in 'notmuch setup' always failing to create a new config file. Fix by checking ENOENT from realpath(3).

cli: config: do not overwrite symlinks when saving config file

2013-04-14T21:38:07Z

Use realpath to canonicalize the config path before writing. Previously 'notmuch setup' and 'notmuch config set' overwrote the config file even if it was a symbolic link.

cli: config: remove unnecessary braces from if blocks

2013-03-30T22:30:06Z

Cosmetic change to drop unnecessary braces that don't even conform to the prevailing coding style.

cli: move config open/close to main() from subcommands

2013-03-08T11:54:41Z

This allows specifying config file as a top level argument to notmuch, and generally makes it possible to override config file options in main(), without having to touch the subcommands. If the config file does not exist, one will be created for the notmuch main command and setup and help subcommands. Help is special in this regard; the config is created just to avoid errors about missing config, but it will not be saved. This also makes notmuch config the talloc context for subcommands.

cli: config: make notmuch_config_open() "is new" parameter input only

2013-03-07T13:39:12Z

We now have a notmuch_config_is_new() function to query whether a config was created or not. Change the notmuch_config_open() is_new parameter into boolean create_new to determine whether the function should create a new config if one doesn't exist. This reduces the complexity of the API.

cli: config: keep track of whether the config is newly created

2013-03-07T13:39:05Z

Keep track of whether the config is newly created, and add notmuch_config_is_new() accessor function to query this. This is to support anyone with a config handle to check this, instead of just whoever called notmuch_config_open().