notmuch/notmuch-config.c, branch 0.24

notmuch-config: ENOENT vs generic handling when file open fails.

2017-02-28T12:08:26Z

When opening configuration file fails, ENOENT (file not found) is handled specially -- in setup missing file is ok (often expected), and otherwise user can be informed to run notmuch setup. In any other case the the reason is unknown, so there is no other option but to print generic error message to stderr.

cli/config: don't try to open config file for 'notmuch help'

2017-02-28T12:08:11Z

The help command does not really need to try to open the config file. So don't.

cli/config: rename name to key in _config_set_list

2017-01-07T12:24:28Z

The other getters and setters speak of key, follow suit. No functional changes.

cli/config: allocate config using talloc_zero

2017-01-07T12:24:07Z

Do not initialize each field separately. It's more robust to allocate the config with zero initialization, and only set the non-zero defaults individually.

notmuch-config: replace config reading function

2016-12-15T23:34:30Z

Config files are currently read using glib's g_key_file_load_from_file function which is very inconvenient because it's limited by design to read only from "regular data files" in a filesystem. Because of this limitation notmuch can't read configs from pipes, fifos, sockets, stdin, etc. Not even "notmuch --config=/dev/stdin" works: Error reading configuration file /dev/stdin: Not a regular file So replace g_key_file_load_from_file with g_key_file_load_from_data which gives us much more freedom to read configs from multiple sources. This also helps the more security sensitive users: If someone has private information in the config file, it can be encrypted on disk, then decrypted in RAM and passed through a pipe directly to notmuch without the use of intermediate plain text files. Signed-off-by: Ioan-Adrian Ratiu

cli: abstract config file reading to a separate function

2016-12-15T23:34:21Z

Simplify and fix the coding style while at it.

lib: add built_with handling for XAPIAN_DB_RETRY_LOCK

2016-06-29T07:05:49Z

This support will be present only if the appropriate version of xapian is available _and_ the user did not disable the feature when building. So there really needs to be some way for the user to check.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

CLI: add notmuch-config support for named queries

2016-05-25T10:40:44Z

Most of the infrastructure here is general, only the validation/dispatch is hardcoded to a particular prefix. A notable change in behaviour is that notmuch-config now opens the database e.g. on every call to list, which fails with an error message if the database doesn't exit yet.

lib/cli: add library API / CLI for compile time options

2016-05-13T10:29:12Z

This is intentionally low tech; if we have more than two options it may make sense to build up what infrastructure is provided.