notmuch/notmuch-config.c, branch 0.26.2

indexing: Change from try_decrypt to decrypt

2017-12-08T12:05:53Z

the command-line interface for indexing (reindex, new, insert) used --try-decrypt; and the configuration records used index.try_decrypt. But by comparison with "show" and "reply", there doesn't seem to be any reason for the "try" prefix. This changeset adjusts the command-line interface and the configuration interface. For the moment, i've left indexopts_{set,get}_try_decrypt alone. The subsequent changeset will address those.

config: define new option index.try_decrypt

2017-10-21T22:54:33Z

By default, notmuch won't try to decrypt on indexing. With this patch, we make it possible to indicate a per-database preference using the config variable "index.try_decrypt", which by default will be false. At indexing time, the database needs some way to know its internal defaults for how to index encrypted parts. It shouldn't be contingent on an external config file (since that can't be retrieved from the database object itself), so we store it in the database. This behaves similarly to the query.* configurations, which are also stored in the database itself, so we're not introducing any new dependencies by requiring that it be stored in the database.

config: test whether an item is stored in the database by name

2017-10-21T22:54:24Z

QUERY_STRING was only used in two places, both to test whether a variable should be stored in (or retrieved from) the database. Since other configuration variables might be stored in the database in the future, consolidate that test into a single function. We also document that these configuration options should not be placed in the config file.

cli: convert notmuch_bool_t to stdbool

2017-10-10T01:24:02Z

C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool.

config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0

2017-07-15T00:23:52Z

gmime 3.0 no longer offers a means to set the path for gpg. Users can set $PATH anyway if they want to pick a differently-installed gpg (e.g. /usr/local/bin/gpg), so this isn't much of a reduction in functionality. The one main difference is for people who have tried to use "gpg2" to make use of gpg 2.1, but that isn't usefully co-installable anyway.

notmuch-config: ENOENT vs generic handling when file open fails.

2017-02-28T12:08:26Z

When opening configuration file fails, ENOENT (file not found) is handled specially -- in setup missing file is ok (often expected), and otherwise user can be informed to run notmuch setup. In any other case the the reason is unknown, so there is no other option but to print generic error message to stderr.

cli/config: don't try to open config file for 'notmuch help'

2017-02-28T12:08:11Z

The help command does not really need to try to open the config file. So don't.

cli/config: rename name to key in _config_set_list

2017-01-07T12:24:28Z

The other getters and setters speak of key, follow suit. No functional changes.

cli/config: allocate config using talloc_zero

2017-01-07T12:24:07Z

Do not initialize each field separately. It's more robust to allocate the config with zero initialization, and only set the non-zero defaults individually.

notmuch-config: replace config reading function

2016-12-15T23:34:30Z

Config files are currently read using glib's g_key_file_load_from_file function which is very inconvenient because it's limited by design to read only from "regular data files" in a filesystem. Because of this limitation notmuch can't read configs from pipes, fifos, sockets, stdin, etc. Not even "notmuch --config=/dev/stdin" works: Error reading configuration file /dev/stdin: Not a regular file So replace g_key_file_load_from_file with g_key_file_load_from_data which gives us much more freedom to read configs from multiple sources. This also helps the more security sensitive users: If someone has private information in the config file, it can be encrypted on disk, then decrypted in RAM and passed through a pipe directly to notmuch without the use of intermediate plain text files. Signed-off-by: Ioan-Adrian Ratiu