notmuch/notmuch-config.c, branch 0.32.1

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

CLI: rename notmuch_config_t to notmuch_conffile_t

2021-04-07T00:32:36Z

The name is a compromise between keeping function names from getting too long, and avoiding confusion with the newer notmuch_config library API. Try to make clear that the residual functionality is only about updating configuration files.

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

CLI/config: remove calls to notmuch_config_open from top level

2021-04-07T00:32:36Z

This will allow simplifying the subcommand interface. Change the internal API to notmuch_config_open to not tie it to the implementation of subcommands in notmuch.c. It also fixes a previously broken test, since notmuch_config_open does not understand the notion of the empty string as a config file name.

CLI/config: default to storing all config in external files

2021-03-27T12:26:14Z

Previously the fact that some configuration options were only stored in the database (and thus editing the config file had no effect) was a source of user confusion. This was fixed with the series ending at d9af0af1646. On the other hand, the underlying partition of config options into those stored by default in the database and those stored in the config file remained. This is also confusing, since now some invocations of "notmuch config set" modify the config file, and others silently modify the database instead. With this commit, it is up to the user to decide which configuration to modify. A new "--database" option is provided for notmuch config to enable modifying the configuration information in the database; otherwise the default is to update an external config file.

CLI/config: drop cached data from notmuch_config_t

2021-03-27T12:26:14Z

The idea is to preserve notmuch_config_t as a thin wrapper for GKeyFile.

CLI/config: drop obsolete notmuch_config_get_*

2021-03-27T12:26:14Z

These are no longer used, replaced by notmuch_config_get.

CLI/config: use notmuch_database_reopen

2021-03-27T12:26:14Z

This allows `notmuch config` to use the common configuration information carried by the notmuch_database_t opened at the top level.

CLI/config: migrate notmuch_config_open to new config

2021-03-27T12:26:14Z

notmuch_config_open will be preserved in the medium term for use by the commands that are manipulating the config file directly (config and setup)

CLI/config: switch "notmuch config list" to merged config

2021-03-27T12:26:14Z

Use the database opened at the top level rather than opening another notmuch_database_t. Test output changes because keys are now listed in alphabetical order, and because a missing database is no longer an error.