notmuch/notmuch-config.c, branch 0.34.3

CLI/config support saving s-expression queries

2021-09-05T00:07:19Z

This commit does not enable using saved s-expression queries, only saving and retrieving them from the config file or the database. Use in queries will be enabled in a following commit.

configure: optional library sfsexp

2021-09-05T00:07:19Z

The configure part is essentially the same as the other checks using pkg-config. Since the optional inclusion of this feature changes what options are available to the user, include it in the "built_with" pseudo-configuration keys.

CLI: make variable n_requested_db_uuid file scope.

2021-09-05T00:07:19Z

It turns out that now that we pass an open database into the subcommands, it is easy to check any requested uuid against the database at the same time as we process the other shared arguments. This results in overall less boilerplate code, as well as making a CLI scope function and variable file scope in notmuch.c.

Merge tag 'debian/0.32.3-1'

2021-08-19T04:46:42Z

notmuch release 0.32.3-1 for unstable (sid) [dgit] [dgit distro=debian no-split --quilt=linear]

CLI/config: restore "notmuch config get built_with.*"

2021-08-18T00:09:56Z

We need to special case the config section "built_with" because it is not (currently) handled by the library. This seems consist with the other sub-sub-commands 'list' and 'set'.

CLI/config: make immutable tables const

2021-05-14T09:41:51Z

Let the compiler help us catch bugs.

compat: rename {,notmuch_}canonicalize_file_name

2021-04-24T11:07:00Z

When compat canonicalize_file_name was introduced, it was limited to C code only because it was used by C code only during that time. >From 5ec6fd4d, (lib/open: check for split configuration when creating database., 2021-02-16), lib/open.cc, which is C++, relies on the existent of canonicalize_file_name. However, we can't blindly enable canonicalize_file_name for C++ code, because different implementation has different additional signature for C++ and users can arbitrarily add -DHAVE_CANONICALIZE_FILE_NAME=0 to {C,CXX}FLAGS. Let's move our implementation into a util library. Helped-by: Tomi Ollila Signed-off-by: Đoàn Trần Công Danh

CLI: rename notmuch_config_t to notmuch_conffile_t

2021-04-07T00:32:36Z

The name is a compromise between keeping function names from getting too long, and avoiding confusion with the newer notmuch_config library API. Try to make clear that the residual functionality is only about updating configuration files.

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

CLI/config: remove calls to notmuch_config_open from top level

2021-04-07T00:32:36Z

This will allow simplifying the subcommand interface. Change the internal API to notmuch_config_open to not tie it to the implementation of subcommands in notmuch.c. It also fixes a previously broken test, since notmuch_config_open does not understand the notion of the empty string as a config file name.