thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.28_rc0 2017-10-15T22:22:40Z 2017-10-15T22:22:40Z Jani Nikula jani@nikula.org 2017-10-14T20:18:36Z urn:sha1:ab8b40f7e350c0661dda5b9d52041150ed339a39 Commit 0f314c0c99be ("cli: convert notmuch_bool_t to stdbool") over-eagerly converted EXCLUDE_TRUE and EXCLUDE_FALSE to EXCLUDE_true and EXCLUDE_false in notmuch-count.c. We could just fix the case back, but convert the option to an actual boolean argument instead. We've used a keyword argument rather than a boolean argument for notmuch count --exclude for five years, since commit 785c1e497f05 ("cli: move count to the new --exclude=(true|false|flag) naming scheme."), "to allow future options to be added more easily". I think we can conclude future options aren't coming any time soon. 2017-10-10T01:24:02Z Jani Nikula jani@nikula.org 2017-10-07T08:44:04Z urn:sha1:0f314c0c99befea599a68bea51d759b4133efef6 C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool. 2017-10-05T01:00:42Z Jani Nikula jani@nikula.org 2017-10-01T20:53:11Z urn:sha1:4a6721970a42a9f86149fb5d395d1001fed2d305 Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output variables, where the output variable being non-NULL determines the type. Introduce checks to ensure only one is set. The downside is some waste of const space per argument; this could be saved by retaining opt_type and using a union, but that's still pretty verbose. - Fix some variables due to the type safety. Mostly a good thing, but leads to some enums being changed to ints. This is pedantically correct, but somewhat annoying. We could also cast, but that defeats the purpose a bit. - Terminate the opt desc arrays using {}. The output variable type safety and the ability to add new fields for just some output types or arguments are the big wins. For example, if we wanted to add a variable to set when the argument is present, we could do so for just the arguments that need it. Beauty is in the eye of the beholder, but I think this looks nice when defining the arguments, and reduces some of the verbosity we have there. 2017-08-30T10:10:07Z David Bremner david@tethera.net 2017-08-26T14:41:38Z urn:sha1:c960bb4686429b220419f6d45ede920d6c14c3c5 Fix the following cppcheck errors: notmuch-count.c:207: error: Resource leak: input notmuch-tag.c:238: error: Resource leak: input We know that the program is shutting down here, but it does no harm to clean up a bit. 2017-06-25T12:39:35Z Piotr Trojanek piotr.trojanek@gmail.com 2017-06-16T22:50:25Z urn:sha1:85c830405886207196aedbd0a2b757b227ba769d 2017-03-22T11:47:13Z David Bremner david@tethera.net 2017-02-18T15:08:04Z urn:sha1:242d5a3ed5ed85bb935c8ed4a4678d7596d8534d Since this is an ABI breaking change, but we already bumped the SONAME for the next release 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:35Z urn:sha1:3721bd45d72e50436ee760b03ae533d49bbb8724 This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:34Z urn:sha1:5ce8e0b11b40f733e6231d2067764e76717a341a This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. One or two remaining uses of the (removed) non-status returning version fixed at the same time 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:32Z urn:sha1:86cbd215eb67d7b996c977352a50e70c101cb641 This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.