notmuch/notmuch-dump.c, branch 0.14

notmuch-dump: remove deprecated positional argument for output file

2012-08-06T11:52:33Z

The syntax --output=filename is a smaller change than deleting the output argument completely, and conceivably useful e.g. when running notmuch under a debugger.

lib/cli: Make notmuch_database_open return a status code

2012-05-05T13:11:57Z

It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest of atomicity, this also updates every use in the CLI so that notmuch still compiles. Since this patch does not update the bindings, the Python bindings test fails.

Use notmuch_database_destroy instead of notmuch_database_close

2012-04-28T12:27:33Z

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

notmuch-dump: convert to command-line-arguments

2011-12-09T00:24:24Z

The output file is handled via positional arguments. There are currently no "normal" options.

notmuch-dump.c: whitespace cleanup

2011-12-04T15:28:42Z

dump: Don't sort the output by message id.

2011-11-28T15:57:45Z

Asking xapian to sort the messages for us causes suboptimal IO patterns. This would be useful, if we only wanted the first few results, but since we want everything anyway, this is pessimization. On 2011-10-29, a measurement on a 372981 messages instance showed that wall time can be reduced from 28 minutes (sorted by Message-ID) to 15 minutes (unsorted). Timings on 189605 messages: $ time notmuch.old dump 19.48user 5.83system 12:10.42elapsed 3%CPU (0avgtext+0avgdata 110656maxresident)k 3629584inputs+22720outputs (33major+7073minor)pagefaults 0swaps $ echo 3 > /proc/sys/vm/drop_caches $ time notmuch.new 14.89user 1.20system 3:23.58elapsed 7%CPU (0avgtext+0avgdata 46032maxresident)k 1256264inputs+22464outputs (43major+1990minor)pagefaults 0swaps

cli: change argument parsing convention for subcommands

2011-10-22T22:42:54Z

previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command line arguments in the subcommand, including possibly using off-the-shelf routines like getopt_long that expect the name of the command in argv[0].

notmuch-dump: deprecate use of output file argument.

2011-10-16T22:59:53Z

We print an intentionally non-specific message on stderr, since it isn't clear if there will be some global output file argument to replace. We update the test suite atomically, since it relies on having the same text in two files.

notmuch-dump: treat any remaining arguments after the filename as search terms

2011-10-16T22:59:53Z

The main motivation here is allow the fast dumping of tag data for messages having certain tags. In practice it seems too slow to pipe dump to grep. All dump-restore tests should be working now, so we update test/dump-restore accordingly

notmuch-dump: update handling of file name argument

2011-10-16T22:59:53Z

We permit -- as an "option processing terminator". Currently this does not do anything useful, but we plan to add search terms after the --.