notmuch/notmuch-dump.c, branch 0.35_rc0thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.35_rc02021-09-05T00:07:19ZCLI/{count, dump, reindex, reply, show}: enable sexp queries2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:43Zurn:sha1:2944d5913319056dfec5c23065932fd1c87a96f6
The change in each case is to call notmuch_query_create_with_syntax,
relying on the already inherited shared options. As a bonus we get
improved error handling from the new query creation API.
The remaining subcommand is 'tag', which is a bit trickier.
CLI: make variable n_requested_db_uuid file scope.2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:10Zurn:sha1:d447b694b498c3e18a22f1eb15139a798c6aab26
It turns out that now that we pass an open database into the
subcommands, it is easy to check any requested uuid against the
database at the same time as we process the other shared
arguments. This results in overall less boilerplate code, as well as
making a CLI scope function and variable file scope in notmuch.c.
CLI: drop notmuch_config_t from subcommand interface.2021-04-07T00:32:36ZDavid Bremnerdavid@tethera.net2021-02-27T14:07:45Zurn:sha1:1c747a501c0ed7df5eaa2b994b9ad11d8981c62c
At this point it is unused in all subcommands.
cli: run uncrustify2021-03-13T12:45:34Zuncrustifydavid@tethera.net2021-03-13T12:45:34Zurn:sha1:eef21c284742fa5ae14d7d352acc3a4dc98821ce
This is the result of running
$ uncrustify --replace --config devel/uncrustify.cfg *.c *.h
in the top level source directory
Line breaks were then adjusted manually to keep argc and argv
together.
cli/dump: convert to new config framework2021-02-06T23:12:34ZDavid Bremnerdavid@tethera.net2020-08-26T10:54:10Zurn:sha1:53f27aaf73192babf831e907ade71dc16f6880be
This conversion is trivial because the only configuration information
accessed by dump is that stored in the database (in order to dump
it). We do need to be careful to keep the write lock on the database
to ensure dump consistency.
CLI: add (unused) database argument to subcommands.2021-02-06T23:05:19ZDavid Bremnerdavid@tethera.net2020-12-21T12:55:14Zurn:sha1:319efe21c9d2754c99951cecc71184faf7ca9054
This will allow transitioning individual subcommands to the new
configuration framework. Eventually when they are all converted we can
remove the notmuch_config_t * argument.
For now, live with the parameter shadowing in some some subcommands;
it will go away when they are converted.
cli/dump: replace use of gzprintf with gzputs for config values2020-04-13T20:14:50ZDavid Bremnerdavid@tethera.net2020-04-13T02:01:38Zurn:sha1:690e36bacd5e53c45775586024ca70f069ca68ad
These can be large, and hit buffer limitations of gzprintf.
cli/dump: define GZPUTS and use it in notmuch-dump2020-04-13T20:14:50ZDavid Bremnerdavid@tethera.net2020-04-13T01:59:12Zurn:sha1:24ff33082ab1a35c7a31835fba80ade145596422
Similarly to GZPRINTF, this is a drop in replacement that can be
improved where needd.
cli/dump: define GZPRINTF macro and use it in place of gzprintf2020-04-13T20:14:50ZDavid Bremnerdavid@tethera.net2020-04-13T01:39:11Zurn:sha1:0d0918f604c5da419c08e3bfae005a4820395997
This will at least catch errors, and can be replaced with more
sophisticated error handling where appropriate.
don't pass NULL as second parameter to gzerror2020-04-13T20:13:55ZDavid Bremnerdavid@tethera.net2020-04-12T23:00:31Zurn:sha1:2c1f783f5f4ad28d89f2e83d7253bae7bba98440
Although (as of 1.2.11) zlib checks this parameter before writing to
it, the docs don't promise to keep doing so, so be safe.