notmuch/notmuch-new.c, branch 0.11_rc2

notmuch: Quiet buildbot warnings.

2011-12-21T11:32:16Z

Cast away the result of various *write functions. Provide a default value for some variables to avoid "use before set" warnings.

cli: add support for pre and post notmuch new hooks

2011-12-11T17:58:15Z

Run notmuch new pre and post hooks, named "pre-new" and "post-new", if present in the notmuch hooks directory. The hooks will be run before and after incorporating new messages to the database. Typical use cases for pre-new and post-new hooks are fetching or delivering new mail to the maildir, and custom tagging of the mail incorporated to the database. Also add command line option --no-hooks to notmuch new to bypass the hooks. Signed-off-by: Jani Nikula

cli: change argument parsing convention for subcommands

2011-10-22T22:42:54Z

previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command line arguments in the subcommand, including possibly using off-the-shelf routines like getopt_long that expect the name of the command in argv[0].

lib: make find_message{,by_filename) report errors

2011-10-04T04:55:29Z

Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my mail "id:871uv2unfd.fsf@gmail.com" Make these functions accept a pointer to 'notmuch_message_t' as argument and return notmuch_status_t which may be used to check for any error condition. restore: Modify for the new notmuch_database_find_message() new: Modify for the new notmuch_database_find_message_by_filename()

new: Wrap adding and removing messages in atomic sections.

2011-09-24T23:00:29Z

This addresses atomicity of tag synchronization, the last atomicity problems in notmuch new. Each message add or remove is wrapped in its own atomic section, so interrupting notmuch new doesn't lose progress.

new: Synchronize maildir flags eagerly.

2011-09-24T23:00:28Z

Because flag synchronization is stateless, it can be performed at any time as long as it's guaranteed to be performed after any change to a message's filename list. Take advantage of this to synchronize tags immediately after a filename is added or removed. This does not yet make adding or removing a message atomic, but it is a big step toward atomicity because it reduces the window where the database tags are inconsistent from nearly the entire notmuch-new to just around when the message is added or removed.

new: Cleanup. De-duplicate file name removal code.

2011-09-24T23:00:28Z

Previously, file name removal was implemented identically in two places. Now it's captured in one function. This is important because file name removal is about to get slightly more complicated with eager tag synchronization and correct removal atomicity.

new: Cleanup. Put removed/renamed message count in add_files_state_t.

2011-09-24T23:00:28Z

Previously, pointers to these variables were passed around individually. This was okay when only one function needed them, but we're about to need them in a few more places.

lib: Add support for nested atomic sections.

2011-09-24T01:50:38Z

notmuch_database_t now keeps a nesting count and we only start a transaction or commit for the outermost atomic section. Introduces a new error, NOTMUCH_STATUS_UNBALANCED_ATOMIC.

new: Defer updating directory mtimes until the end.

2011-09-24T01:50:38Z

Previously, if notmuch new were interrupted between updating the directory mtime and handling removals from that directory, a subsequent notmuch new would not handle those removals until something else changed in that directory. This defers recording the updated mtime until after removals are handled to eliminate this problem.