notmuch/notmuch-new.c, branch 0.13.2

new: Remove workaround for detecting newly created directory objects

2012-05-24T01:31:10Z

Previously, notmuch_database_get_directory did not indicate whether or not the returned directory object was newly created, which required a workaround to distinguish newly created directory objects with no child messages from directory objects that had no mtime set but did have child messages. Now that notmuch_database_get_directory distinguishes whether or not the directory object exists in the database, this workaround is no longer necessary.

lib/cli: Make notmuch_database_get_directory return a status code

2012-05-15T11:56:33Z

Previously, notmuch_database_get_directory had no way to indicate how it had failed. This changes its prototype to return a status code and set an out-argument to the retrieved directory, like similar functions in the library API. This does *not* change its currently broken behavior of creating directory objects when they don't exist, but it does document it and paves the way for fixing this. Also, it can now check for a read-only database and return NOTMUCH_STATUS_READ_ONLY_DATABASE instead of crashing. In the interest of atomicity, this also updates calls from the CLI so that notmuch still compiles.

lib/cli: Make notmuch_database_create return a status code

2012-05-05T13:12:26Z

This is the notmuch_database_create equivalent of the previous change. In this case, there were places where errors were not being propagated correctly in notmuch_database_create or in calls to it. These have been fixed, using the new status value.

lib/cli: Make notmuch_database_open return a status code

2012-05-05T13:11:57Z

It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest of atomicity, this also updates every use in the CLI so that notmuch still compiles. Since this patch does not update the bindings, the Python bindings test fails.

Use notmuch_database_destroy instead of notmuch_database_close

2012-04-28T12:27:33Z

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

new: Fix missing end_atomic in remove_filename on error

2012-04-25T02:25:52Z

Previously, if we failed to find the message by filename in remove_filename, we would return immediately from the function without ending its atomic block. Now this code follows the usual goto DONE idiom to perform cleanup.

new: Print final fatal error message to stderr

2012-04-25T02:25:52Z

This was going to stdout. I removed the newline at the beginning of printing the fatal error message because it wouldn't make sense if you were only looking at the stderr stream (e.g., you had redirected stdout to /dev/null).

new: Handle fatal errors in remove_filename and _remove_directory

2012-04-25T02:25:51Z

Previously such errors were simply ignored. Now they cause an immediate cleanup and abort.

new: Consistently treat fatal errors as fatal

2012-04-25T02:25:51Z

Previously, fatal errors in add_files_recursive were not treated as fatal by its callers (including itself!). This makes add_files_recursive errors consistently fatal and updates all callers to treat them as fatal.

add support for user-specified files & directories to ignore

2012-02-17T12:04:34Z

A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8.fsf@tyndall.ie"