notmuch/notmuch-new.c, branch 0.18 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.18 2014-04-12T10:59:44Z notmuch-new: backup tags before database upgrade 2014-04-12T10:59:44Z David Bremner david@tethera.net 2014-04-01T14:06:05Z urn:sha1:a7eaa4d84a909275fe0c089f8dbf346ebcdc69c6 All we do here is calculate the backup filename, and call the existing dump routine. Also take the opportunity to add a message about being safe to interrupt. cli: make sure notmuch new and insert don't add invalid tags 2014-03-06T11:42:10Z Jani Nikula jani@nikula.org 2014-02-23T16:55:22Z urn:sha1:e8ec38c25afefacff8c2adb6e4f9e53df9870746 Check new.tags configuration values before doing anything, and bail out on invalid values. new: Detect dirent.d_type support at configure time 2014-02-14T12:42:45Z Austin Clements amdragon@MIT.EDU 2014-02-13T06:50:59Z urn:sha1:b1fa95721bd54c60c367ae4fb54279404656a070 Support for dirent.d_type is OS-specific. Previously, we used _DIRENT_HAVE_D_TYPE to detect support for this, but this is apparently a glic-ism (FreeBSD, for example, supports d_type, but does not define this). Since there's no cross-platform way to detect support for dirent.d_type, detect it using a test compile at configure time. cli: add --quiet option to notmuch new 2014-01-26T13:49:00Z Jani Nikula jani@nikula.org 2014-01-19T20:32:27Z urn:sha1:e932fca54fc88bba75eda01c3e7f6ddf92a56759 Tie it to --verbose (resulting in verbosity levels of quiet, normal, and verbose) but leave --debug orthogonal. Do some drive-by cleaning while at it. cli: abstract notmuch new result printing 2014-01-26T13:44:42Z Jani Nikula jani@nikula.org 2014-01-19T20:32:26Z urn:sha1:12621980ee19aa36c76ad16500c4f5a43ca6c6ca The notmuch_new_command() function has grown huge, chop it up a bit. This should also be helpful when adding a --quiet option to notmuch new. No functional changes. cli: for loop is more customary 2014-01-26T13:41:29Z Jani Nikula jani@nikula.org 2014-01-19T20:32:25Z urn:sha1:f849b371cc78fac73d9a8e0467bc0e6232ced18b With the happy day stop condition within the while, it was confusing. Switch to the paradigm for loop. No functional changes. cli: use dirent_type in count_files too 2014-01-26T13:38:22Z Jani Nikula jani@nikula.org 2014-01-19T20:32:24Z urn:sha1:0b247cb411fa7530003bad920bd2c85ed46187b5 Avoid an extra stat per file, if possible, also when counting the files for initial indexing. cli: only check the ignore list if needed 2014-01-26T13:37:01Z Jani Nikula jani@nikula.org 2014-01-19T20:32:23Z urn:sha1:65ebd34329e31a9a8a6f4a2d1e255ef273b0678e Premature optimization is the root of all evil, but this is simple enough. cli: extract single message addition in notmuch new to clarify code 2014-01-26T13:36:51Z Jani Nikula jani@nikula.org 2014-01-19T20:32:22Z urn:sha1:caf5514a3692d6ad6be257a24a5b5a44164bb90a The add_files() function has grown huge, chop it up a bit. No functional changes. cli: clean up exit status code returned by the cli commands 2014-01-18T18:45:26Z Jani Nikula jani@nikula.org 2014-01-10T21:28:53Z urn:sha1:c7453773064efbd0b2cd17b15ba483edbd28ce1e Apart from the status codes for format mismatches, the non-zero exit status codes have been arbitrary. Make the cli consistently return either EXIT_SUCCESS or EXIT_FAILURE.