notmuch/notmuch-new.c, branch 0.23.3

cli: consider files vanishing during notmuch new non-fatal

2016-11-26T01:09:32Z

If some software other than notmuch new renames or removes files during the notmuch new scan (specifically after scandir but before indexing the file), keep going instead of bailing out. Failing to index the file is just a race condition between notmuch and the other software; the rename could happen after the notmuch new scan anyway. It's not fatal, and we'll catch the renamed files on the next scan. Add a new exit code for when files vanished, so the caller has a chance to detect the race and re-run notmuch new to recover. Reported by Paul Wise at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843127

CLI: add properties to dump output

2016-09-21T21:14:25Z

Part of providing extensibility via properties is to make sure that user data is not lost. Thus we need to be able to dump and restore properties.

Use https instead of http where possible

2016-06-05T11:32:17Z

Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests.

CLI: add optional config data to dump output.

2016-05-25T10:07:56Z

Note that it changes the default dump output format, but doesn't break existing notmuch-restore. It might break user scripts though.

cli: remove leftover dir variable

2016-05-02T10:33:13Z

No functional changes.

cli/new: add better error messages for FILE_ERROR

2016-03-30T02:07:00Z

The code in add_file seems to assume that NOTMUCH_STATUS_FILE_ERROR is never returned from add_message. This turns out to be false (although it seems to only happen in certain fairly rare race conditions).

cli: fix function name in notmuch new debug logging

2015-12-30T15:28:30Z

add_files_recursive has been renamed add_files long ago.

cli: delete directory documents on directory removal

2015-10-14T10:55:41Z

There was a problem with the directory documents being left behind when the filesystem directory was removed. This was worked around in [1]. However, that ignored the fact that the directory documents are also still listed by notmuch_directory_get_child_directories() leading to confusing results when running notmuch new. The directory documents are found and queued for removal over and over again. Fix the problem for real by removing the directory documents. This fixes the tests flagged as broken in [2]. The (non-deterministic) hack test from [3] also still passes with this change. [1] commit acd66cdec075312944e527febd46382e54d99367 [2] commit ed9ceda623d3f22fb66365b33db63c5c982067d3 [3] id:1441445731-4362-1-git-send-email-jani@nikula.org

cli: use designated initializer to initialize add_files_state

2015-09-29T11:25:25Z

The side effect is that all of add_files_state will be initialized to zero, removing any lingering doubt that some of it might not be initialized. It's not a small struct, and the initialization is scattered around a bit, so this makes the code more readable.

cli: reset db directory mtime upon directory removal

2015-09-07T12:28:00Z

The library does not have a function to remove a directory document for a path. Usually this doesn't matter except for a slight waste of space. However, if the same directory gets added to the filesystem again, the old directory document is found with the old mtime. Reset the directory mtime on removal to avoid problems. The corner case that can hit this problem is renaming directories back and forth. Renaming does not change the mtime of the directory in the filesystem, and thus the old db directory document mtime may match the fs mtime of the directory. The long term fix might be to add a library function to remove a directory document, however this is a much simpler and faster fix for the time being.