notmuch/notmuch-reindex.c, branch 0.32

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

cli: run uncrustify

2021-03-13T12:45:34Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory Line breaks were then adjusted manually to keep argc and argv together.

cli/reindex: convert new config framework

2021-02-06T23:19:18Z

The only non-trivial part is switching the talloc context for query_string_from args from 'config' to 'notmuch'.

CLI: add (unused) database argument to subcommands.

2021-02-06T23:05:19Z

This will allow transitioning individual subcommands to the new configuration framework. Eventually when they are all converted we can remove the notmuch_config_t * argument. For now, live with the parameter shadowing in some some subcommands; it will go away when they are converted.

cli: run uncrustify

2019-06-14T10:41:27Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory

gmime-cleanup: drop all arguments unused in GMime 3

2019-05-03T09:56:38Z

This means dropping GMimeCryptoContext and notmuch_config arguments. All the argument changes are to internal functions, so this is not an API or ABI break. We also get to drop the #define for g_mime_3_unused. signed-off-by: Daniel Kahn Gillmor

CLI/reindex: fix memory leak

2019-04-19T01:15:44Z

Since message is owned by messages, it was held for the entire run of the program. This in turn means that the Xapian::Document objects are not freed, and thus one ends up with (effectively) a copy of one's entire mailstore in memory when running notmuch reindex '*' Thanks to Olly Betts for the patient help debugging, and the suggestion of a fix.

move more http -> https

2018-05-03T23:59:20Z

Correct URLs that have crept into the notmuch codebase with http:// when https:// is possible. As part of this conversion, this changeset also indicates the current preferred upstream URLs for both gmime and sup. the new URLs are https-enabled, the old ones are not. This also fixes T310-emacs.sh, thanks to Bremner for catching it.

cli/reindex: add --try-decrypt=(true|false)

2017-10-21T22:58:52Z

Enable override of the index.try_decrypt setting on a per-run basis when invoking "notmuch reindex". This allows the possibility of (for example) an emacs keybinding that adds the cleartext of the currently shown decrypted message to the index, making it searchable in the future. It also enables one-time indexing of all messages matching some query, like so: notmuch reindex tag:encrypted and\ not property:index.decryption=success and\ from:alice@example.org We also update the documentation and tab completion, and add a few more tests.

cli: use designated initializers for opt desc

2017-10-05T01:00:42Z

Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output variables, where the output variable being non-NULL determines the type. Introduce checks to ensure only one is set. The downside is some waste of const space per argument; this could be saved by retaining opt_type and using a union, but that's still pretty verbose. - Fix some variables due to the type safety. Mostly a good thing, but leads to some enums being changed to ints. This is pedantically correct, but somewhat annoying. We could also cast, but that defeats the purpose a bit. - Terminate the opt desc arrays using {}. The output variable type safety and the ability to add new fields for just some output types or arguments are the big wins. For example, if we wanted to add a variable to set when the argument is present, we could do so for just the arguments that need it. Beauty is in the eye of the beholder, but I think this looks nice when defining the arguments, and reduces some of the verbosity we have there.