notmuch/notmuch-reindex.c, branch master

CLI: move indexopts variable out of shared options block

2021-10-23T12:51:50Z

This reduces the amount of global state. Furthermore, index options can be set (in principle) in several ways, not just in the one function for processing indexing command line options.

CLI/{count, dump, reindex, reply, show}: enable sexp queries

2021-09-05T00:07:19Z

The change in each case is to call notmuch_query_create_with_syntax, relying on the already inherited shared options. As a bonus we get improved error handling from the new query creation API. The remaining subcommand is 'tag', which is a bit trickier.

CLI: make variable n_requested_db_uuid file scope.

2021-09-05T00:07:19Z

It turns out that now that we pass an open database into the subcommands, it is easy to check any requested uuid against the database at the same time as we process the other shared arguments. This results in overall less boilerplate code, as well as making a CLI scope function and variable file scope in notmuch.c.

CLI: make static message strings const

2021-05-14T09:42:55Z

This is both a bit clearer and avoids the possibility of modification.

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

cli: run uncrustify

2021-03-13T12:45:34Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory Line breaks were then adjusted manually to keep argc and argv together.

cli/reindex: convert new config framework

2021-02-06T23:19:18Z

The only non-trivial part is switching the talloc context for query_string_from args from 'config' to 'notmuch'.

CLI: add (unused) database argument to subcommands.

2021-02-06T23:05:19Z

This will allow transitioning individual subcommands to the new configuration framework. Eventually when they are all converted we can remove the notmuch_config_t * argument. For now, live with the parameter shadowing in some some subcommands; it will go away when they are converted.

cli: run uncrustify

2019-06-14T10:41:27Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory

gmime-cleanup: drop all arguments unused in GMime 3

2019-05-03T09:56:38Z

This means dropping GMimeCryptoContext and notmuch_config arguments. All the argument changes are to internal functions, so this is not an API or ABI break. We also get to drop the #define for g_mime_3_unused. signed-off-by: Daniel Kahn Gillmor