thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.1 2010-03-09T17:22:29Z 2010-03-09T17:22:29Z Carl Worth cworth@cworth.org 2010-03-09T17:22:29Z urn:sha1:4e5d2f22db290a830c0267f34b519c6138af00ed We rename 'has_more' to 'valid' so that it can function whether iterating in a forward or reverse direction. We also rename 'advance' to 'move_to_next' to setup parallel naming with the proposed functions 'move_to_first', 'move_to_last', and 'move_to_previous'. 2010-02-04T20:42:09Z Carl Worth cworth@cworth.org 2010-02-04T20:39:11Z urn:sha1:d111c720bad53f98edba958aa605e857036a2bc8 This function detects whether the address in the Reply-To header already appears in either To or Cc. So give it a name that reflects what it does (reply_to_header_is_redundant) rather than the old name which described one possible use of the function, (as a simple heuristic for detecting whether a mailing list had applied reply-to munging). 2010-02-04T20:42:09Z Carl Worth cworth@cworth.org 2010-02-04T20:32:28Z urn:sha1:62379f3dee5bc3673007271bc43ecc2587ac4e22 Apparently, GMime doesn't want to create a valid address list object for an empty string. That's annoying, but it's easy enough to test for the empty string and avoid the problem. 2010-02-04T20:42:09Z Carl Worth cworth@cworth.org 2010-02-04T20:29:04Z urn:sha1:82e47ec92b41973567f4d89bbd6afdb22fc634bd This change was already recommended in a comment in the original implementation of this patch. If someone really wants to support un-munging in the case of To: and Reply-To: having the same address but different case, then they can provide a portable approach for that. 2010-02-04T20:42:09Z Carl Worth cworth@cworth.org 2010-02-04T20:27:42Z urn:sha1:aea35aa5c6ccc9a1490e9ef387f37f5547c88605 The condition was using a reversed sense for the test of the return value of strcasestr, (perhaps confusing it with the usage of strcmp?). 2010-02-04T20:42:09Z Carl Worth cworth@cworth.org 2010-02-04T20:12:01Z urn:sha1:9953e9a5a85b3ffbf62b86a6aa9bd0322d425f81 Some recently-added functions were to hard for me to read without the expected whitespace. Fix these. 2010-02-04T20:10:43Z Jed Brown jed@59A2.org 2009-11-28T23:19:36Z urn:sha1:fddd3d831b6a34a47b1e68fcaa1bc63d54240df5 Some mailing lists engage in the evil practice of changing the Reply-To header so that replies from all mailers go to the list by default, at the expense of not responding to the person who actually sent the message. When this is detected, we reply to `From' and remove the duplicate response to the mailing list. Consider a reply to the following message. From: Some User <some.user@example.com> To: Sample users list <sample-users@sample.org> Reply-To: Sample users list <sample-users@sample.org> Prior to this patch, `notmuch reply' produces To: Sample users list <sample-users@sample.org>, Sample users list <sample-users@sample.org> and after the patch, To: Some User <some.user@example.com>, Sample users list <sample-users@sample.org> Signed-off-by: Jed Brown <jed@59A2.org> 2010-02-04T20:10:43Z Jed Brown jed@59A2.org 2009-11-28T23:19:35Z urn:sha1:fb50f31048272c6b055f9e1bb049fcf18a92310e This code was already duplicated. We move it to a new, shared add_recipients_from_message function, in preparation for more sophisticated mailing list logic. Signed-off-by: Jed Brown <jed@59A2.org> 2009-12-04T00:47:47Z Kan-Ru Chen kanru@kanru.info 2009-11-28T11:58:29Z urn:sha1:c8b50eee284ff880aed955018568a14eff03d129 Pass the message through the charset filter so that we can view messages wrote in different charset encoding. Signed-off-by: Kan-Ru Chen <kanru@kanru.info> 2009-11-28T00:56:51Z Jed Brown jed@59A2.org 2009-11-25T18:02:18Z urn:sha1:00b138ba2ac0c9a01f19d9e0b75657f1082a766d Apparently this is actually the correct way to do it, it's silly to do it wrong just to conform to one of git's internal data structures.