notmuch/notmuch-reply.c, branch 0.12

cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t

2012-02-12T16:58:20Z

Use notmuch_bool_t instead of int for entire_thread, raw, and decrypt boolean fields in notmuch_show_params_t. No functional changes. Signed-off-by: Jani Nikula

show: Introduce mime_node formatter callback

2012-01-25T11:21:40Z

This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter structure can be reduced to only message_set_{start,sep,end} and part, most of show_message can be deleted, and all of show-message.c can be deleted.

Add compatibility with gmime 2.6

2012-01-21T12:52:34Z

There are lots of API changes in gmime 2.6 crypto handling. By adding preprocessor directives, it is however possible to add gmime 2.6 compatibility while preserving compatibility with gmime 2.4 too. This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info". This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test is currently broken (signature verification with signer key unavailable), most likely because of a bug in gmime which will hopefully be fixed in a future version.

cli: pick the user's address in a group list as from address

2012-01-17T01:06:34Z

Messages received to a group list were not replied to using the from address in the list. Fix it. Signed-off-by: Jani Nikula

cli: add support for replying just to the sender in "notmuch reply"

2012-01-14T15:10:28Z

Add new option --reply-to=(all|sender) to "notmuch reply" to select whether to reply to all (sender and all recipients), or just sender. Reply to all remains the default. Credits to Mark Walters for his similar earlier work where I picked up the basic idea of handling reply-to-sender in add_recipients_from_message(). All bugs are mine, though. Signed-off-by: Jani Nikula

cli: slightly refactor "notmuch reply" address scanning functions

2012-01-14T15:10:17Z

Slightly refactor "notmuch reply" recipient and user from address scanning functions in preparation for reply-to-sender feature. Add support for not adding recipients at all (just scan for user from address), and returning the number of recipients added. No externally visible functional changes. Signed-off-by: Jani Nikula

cli: convert "notmuch reply" to use the new argument parser

2012-01-09T10:45:02Z

Use the new notmuch argument parser to handle arguments in "notmuch reply". There should be no functional changes. Signed-off-by: Jani Nikula

cli: fix use of uninitialized variable in "notmuch reply"

2012-01-09T10:44:47Z

notmuch_show_params_t params is only initialized partially in notmuch_reply_command(). The only field that is used uninitialized is params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted messages work by coincidence. Initialize params properly, and set params.decrypt as needed. Signed-off-by: Jani Nikula

show: Pass notmuch_message_t instead of path to show_message_body.

2011-12-26T02:17:27Z

In addition to simplifying the code, we'll need the notmuch_message_t* in show_message_body shortly.

cli: change argument parsing convention for subcommands

2011-10-22T22:42:54Z

previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command line arguments in the subcommand, including possibly using off-the-shelf routines like getopt_long that expect the name of the command in argv[0].