notmuch/notmuch-reply.c, branch 0.2

Decode headers in reply

2010-04-13T16:23:54Z

When headers contain non-ASCII characters, they are encoded according to rfc2047. Nomtuch reply command emits the headers in the encoded form, which makes them hard to read by humans who compose the reply. For example instead of "Subject: Re: Rozlučka" one currently sees "Subject: Re: =?iso-8859-2?q?Rozlu=E8ka?=". This patch adds a new GMime filter which is used to decode headers to UTF-8 and uses this filter when notmuch reply outputs headers. Signed-off-by: Michal Sojka

Fix code extracting the MTA from Received: headers

2010-04-07T22:36:40Z

The previous code made too many assumptions about the (sadly not standardized) format of the Received headers. This version should be more robust to deal with different variations. Signed-off-by: Dirk Hohndel

notmuch-reply: Remove stray brace.

2010-04-07T14:17:12Z

That was breaking the build.

notmuch-reply: Remove a useless level of nesting.

2010-04-07T01:51:57Z

Making the code a tiny bit easier to read (in my opinion at least).

notmuch-reply: Fix some whitespace issues.

2010-04-07T01:51:47Z

No actual code change here. Just whitespace style, (mostly just my preferred space before a left parenthesis, and a space after a comma).

guess From address from Received headers

2010-04-07T01:47:40Z

When replying to a message notmuch tries to pick the correct From address by looking which one of a user's configured email addresses were included in To or Cc headers of the email that is being replied to. If none of the users email addresses are in the To or Cc headers we now try to guess from the first (chronologically, last) Received header which domain this email was received in and therefore which of the email addresses to use in a reply If that fails we still use the primary email as From email Signed-off-by: Dirk Hohndel

lib: Rename iterator functions to prepare for reverse iteration.

2010-03-09T17:22:29Z

We rename 'has_more' to 'valid' so that it can function whether iterating in a forward or reverse direction. We also rename 'advance' to 'move_to_next' to setup parallel naming with the proposed functions 'move_to_first', 'move_to_last', and 'move_to_previous'.

notmuch reply: Rename the mailing_list_munged_reply_to function

2010-02-04T20:42:09Z

This function detects whether the address in the Reply-To header already appears in either To or Cc. So give it a name that reflects what it does (reply_to_header_is_redundant) rather than the old name which described one possible use of the function, (as a simple heuristic for detecting whether a mailing list had applied reply-to munging).

notmuch reply: Prevent GMIME assertion complaints for empty Reply-to header.

2010-02-04T20:42:09Z

Apparently, GMime doesn't want to create a valid address list object for an empty string. That's annoying, but it's easy enough to test for the empty string and avoid the problem.

notmuch reply: Use strstr instead of strcasestr for portability.

2010-02-04T20:42:09Z

This change was already recommended in a comment in the original implementation of this patch. If someone really wants to support un-munging in the case of To: and Reply-To: having the same address but different case, then they can provide a portable approach for that.