thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.23.7 2016-09-17T12:20:12Z 2016-09-17T12:20:12Z Jani Nikula jani@nikula.org 2016-09-13T17:14:22Z urn:sha1:87119b130bf7ec48181a33cd411f566d0234fc19 The notmuch message is no longer needed. Simplify. 2016-09-17T12:18:28Z Jani Nikula jani@nikula.org 2016-09-13T17:14:21Z urn:sha1:e20a7a2fbcaa21926b3ae8c199839b792433767a Use gmime message instead of notmuch message in Reply-To: redundancy detection. This allows us to easily iterate over all recipient email addresses accurately, instead of just scanning for strings in the relevant message headers. This improves the accuracy of the detection in many ways. This also makes the notmuch message parameter to get_sender() unused. This will be cleaned up in a follow-up patch to not make too many changes here at once. 2016-09-17T12:14:20Z Jani Nikula jani@nikula.org 2016-09-13T17:14:20Z urn:sha1:932c0ff879ddaf38f1e4ae325c061132d6af1026 Avoid parsing Reply-To: header into internet address list twice. Move the parsing outside of reply_to_header_is_redundant(), and pass the parsed internet address list in as parameter. This also avoids leaking the memory of one copy of the internet address list. 2016-09-17T12:11:07Z Jani Nikula jani@nikula.org 2016-09-13T17:14:19Z urn:sha1:536b1f9df989915161024d2334e206f538d59f9b Pass in GMimeMessage to simplify To/Cc/Bcc headers. We'll eventually remove the notmuch message passing altogether, but keep both for now to not make too big changes at once. Getting the headers from GMimeMessage using GMime functions fixes the error on duplicate Cc headers reported by Daniel Kahn Gillmor <dkg@fifthhorseman.net> in id:87d1ngv95p.fsf@alice.fifthhorseman.net. Get rid of an intermediate function. The small annoyance is the ownership differences in the address lists. 2016-09-17T12:08:58Z Jani Nikula jani@nikula.org 2016-09-13T17:14:18Z urn:sha1:ca82d481a1040ed3a47ad9c5e7cf7ec16e5e2ced Support passing NULL list later on. Also use it to simplify the recursion. 2016-09-17T12:07:10Z Jani Nikula jani@nikula.org 2016-09-13T17:14:17Z urn:sha1:78520673fa9e42c3f0856913a00a9bf3c7a05489 The main motivation here is to move the special casing around reply-to/from handling into a function of its own, clarifying the main logic. 2016-09-17T12:05:48Z Jani Nikula jani@nikula.org 2016-09-13T17:14:16Z urn:sha1:301a65b0f2f7e4551ded7104d779b8600a806b2b Now that we've made the various reply formats quite similar to each other, there's no point in keeping the abstractions. They are now close enough to be put in one function. For now, a mime node will be uselessly created for the headers-only case, but this is insignificant, and may change in the future. 2016-09-17T12:03:53Z Jani Nikula jani@nikula.org 2016-09-13T17:14:15Z urn:sha1:5e438d95c4671844cf4fddbd16c5744f41cda85c Add an option for "limited" headers for the (slightly misleadingly named) headers-only format. There should be no functional changes. 2016-09-17T12:00:31Z Jani Nikula jani@nikula.org 2016-09-13T17:14:14Z urn:sha1:1e289ed1c9fb8af8696c2735b714438bd115725f Just use strdup when original references is not available, instead of trying to cram everything into a monster asprintf. There should be no functional changes. 2016-09-17T11:53:11Z Jani Nikula jani@nikula.org 2016-09-13T17:14:13Z urn:sha1:b1aca0e502e97ab822da60aa4217d4b0bdb33543 Again, in preparation for later unification, reorganize create_reply_message() to be more similar to the headers-only format reply code in notmuch_reply_format_headers_only(). Due to "pretty" header ordering, there should be no change in output. There should be no functional changes.