notmuch/notmuch-reply.c, branch 0.25.3 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.25.3 2017-07-15T00:23:52Z config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 2017-07-15T00:23:52Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2017-07-14T13:12:00Z urn:sha1:e142de643d3bb4354f70e1490a97b491d1116e95 gmime 3.0 no longer offers a means to set the path for gpg. Users can set $PATH anyway if they want to pick a differently-installed gpg (e.g. /usr/local/bin/gpg), so this isn't much of a reduction in functionality. The one main difference is for people who have tried to use "gpg2" to make use of gpg 2.1, but that isn't usefully co-installable anyway. lib: paper over allocation difference 2017-07-15T00:23:52Z David Bremner david@tethera.net 2017-05-20T12:05:22Z urn:sha1:4ce7591610444a1c5ef6f56b57af8e180437fa62 In gmime 3.0 this function is "transfer none", so no deallocation is needed (or permitted) cli: replace use of g_mime_message_get_recipients 2017-07-14T20:58:09Z David Bremner david@tethera.net 2017-05-06T11:41:14Z urn:sha1:32819f74d3ac2eee25cf234d988688cc82ecbc0a This function, and associated enum, have been renamed and generalized in gmime-3.0. lib/cli: replace use of g_mime_message_get_sender 2017-07-14T20:58:09Z David Bremner david@tethera.net 2017-05-06T02:26:57Z urn:sha1:cbb2d5608ef6dd54d6e9e19b2bb570d3fe54b28b This function changes semantics in gmime-3.0 so make a new function that provides the same functionality in both cli: replace use of g_mime_message_get_reply_to 2017-07-14T20:58:09Z David Bremner david@tethera.net 2017-05-04T18:59:37Z urn:sha1:d7fea369160c548524fd8958ff88d6faacfabe3a This function changes signature in gmime 3.0, so we provide two new functions, one for each signature. cli: replace use of g_mime_message_get_date_as_string 2017-07-14T20:58:09Z David Bremner david@tethera.net 2017-05-04T12:48:44Z urn:sha1:67dbd24ece883e9cb0258fce289e40ca276b729d This function goes away in gmime-3.0. Also, the memory management is apparently error prone, witness the memory leak in notmuch-reply. fix wrong printf formatting of signed/unsigned integers 2017-06-25T12:39:35Z Piotr Trojanek piotr.trojanek@gmail.com 2017-06-16T22:50:25Z urn:sha1:85c830405886207196aedbd0a2b757b227ba769d cli/reply: fix two memory leaks, document a third 2017-05-30T12:02:29Z David Bremner david@tethera.net 2017-05-27T16:51:15Z urn:sha1:233092577cdcb86e3e38374a50a3a26c05474126 internet_address_list_to_string returns an allocated string, which needs to be freed with g_free. g_free can handle a NULL argument, so we follow the usage elsewhere of calling it unconditionally. The third leak we leave as it would require restructuring of add_recipients_from_message, and is fixed by later gmime-3.0 porting. cli/reply: direct all output for text format to gmime stream 2017-05-30T12:01:56Z David Bremner david@tethera.net 2017-05-27T16:51:12Z urn:sha1:555e2abe9d838bcf16d7e44f8aea69ded8ffd7f4 Interleaving printfs with writes to the gmime stream worked when the gmime stream was backed by the FILE *stdout, but that is no longer the case. Create one stream and pass it into the two functions where needed, as well well as replacing printfs with g_mime_stream_printf. lib: replace deprecated n_q_count_messages with status returning version 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:34Z urn:sha1:5ce8e0b11b40f733e6231d2067764e76717a341a This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. One or two remaining uses of the (removed) non-status returning version fixed at the same time