notmuch/notmuch-reply.c, branch 0.4

notmuch: Eliminate some const-correctness warnings.

2010-10-28T01:07:37Z

These were introduced as a side-effect of commit b9eac48c22f53f84ed1d9c1d8ca862a7b638c9ac (shame on me for doing side-effect commits like that!). For me, at least, compilation is now warning-free.

Remove bcc header from notmuch reply.

2010-10-28T00:15:42Z

Notmuch reply should not be Bcc'ing the sender by default. This is not the appropriate way to save copies of sent mail (which should probably be handled by an Fcc header[*]) and it doesn't give the user the option to not be bcc'd. This is really something that should be handled by the reader UI. For instance, emacs message-mode can easily be configured to add Bcc's if the user wishes. [*] Carl Worth: The FCC header is now in place by default in the emacs user-interface (and tested in the test suite) so the Bcc is ready to be eliminated.

Rename already used counter var i

2010-04-27T15:09:38Z

i is already used in a for loop at this point, so using i here again broke notmuch-reply (it would just hang). Use j instead of i here. Signed-off-by: Sebastian Spaeth

Rearchitect From: header guessing code for replies

2010-04-26T21:44:13Z

We want to be able to correctly guess the best From: header to use when replying to emails. This is what we are looking at now: 1 is one of the users' mail addresses in the To: or Cc: header 2 check for an Envelope-to: header 3 check for an X-Original-To: header 4 check for a (for ) clause in Received: headers 5 check for the domain part of known email addresses in the 'by' part of Received headers 6 fall back to the primary email address This patch changes the algorithm for steps 2-5 of this process. Prior to this patch we had a first attempt to implement only step 5 - but this broke in many email setups where mail delivery to the local machine added additional Received: lines. Steps 2-4 are new, step 5 now analyzes the concatenated Received: header (this was in the previous patch) to do this analysis. Signed-off-by: Dirk Hohndel

notmuch reply: Handle notmuch_message_get_header returning NULL.

2010-04-24T13:33:32Z

This seems a rather unlikely case, (replying to a message that disappears out from under us half way through the reply), but notmuch_message_get_header is documented to return NULL in error cases, so we might as well deal sanely with that (rather than just crashing).

Decode headers in reply

2010-04-13T16:23:54Z

When headers contain non-ASCII characters, they are encoded according to rfc2047. Nomtuch reply command emits the headers in the encoded form, which makes them hard to read by humans who compose the reply. For example instead of "Subject: Re: Rozlučka" one currently sees "Subject: Re: =?iso-8859-2?q?Rozlu=E8ka?=". This patch adds a new GMime filter which is used to decode headers to UTF-8 and uses this filter when notmuch reply outputs headers. Signed-off-by: Michal Sojka

Fix code extracting the MTA from Received: headers

2010-04-07T22:36:40Z

The previous code made too many assumptions about the (sadly not standardized) format of the Received headers. This version should be more robust to deal with different variations. Signed-off-by: Dirk Hohndel

notmuch-reply: Remove stray brace.

2010-04-07T14:17:12Z

That was breaking the build.

notmuch-reply: Remove a useless level of nesting.

2010-04-07T01:51:57Z

Making the code a tiny bit easier to read (in my opinion at least).

notmuch-reply: Fix some whitespace issues.

2010-04-07T01:51:47Z

No actual code change here. Just whitespace style, (mostly just my preferred space before a left parenthesis, and a space after a comma).