notmuch/notmuch-reply.c, branch 0.6rc1

Fix indentation in guess_from_received_header().

2011-06-15T14:08:28Z

Fix memory leak in guess_from_received_header().

2011-06-15T14:08:25Z

Mta variable was not free()d in one case.

Fix double free in guess_from_received_header().

2011-06-15T14:08:18Z

Before the change, the last loop in guess_from_received_header() did not reset domain and tld variables to NULL. This leads to double free error in some cases and possibly other bugs.

Use stock GMimeSession by default

2011-06-04T00:42:54Z

Our use of GMimeSession was unneeded boilerplate, and we weren't doing anything with it. This simplifies and clarifies that assumption. If we want to do anything fancier later, the examples in the gmime source are a reasonable source to work from in defining a new GMimeSession derivative. Since GMimeSession is going away in GMime 2.6, though, i don't recommend using it.

Add decryption of PGP/MIME-encrypted parts with --decrypt.

2011-05-27T23:22:00Z

This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire multipart/encrypted part is replaced by the contents of the encrypted part. At the moment only a json part_encstatus formatting function is available, even though decryption is done for all formats. Emacs support to follow.

Add signature verification of PGP/MIME-signed parts with --verify.

2011-05-27T23:22:00Z

This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus formatting function is available. Emacs support to follow. The original work for this patch was done by Daniel Kahn Gillmor whose help with this functionality I greatly appreciate.

Break up format->part function into part_start and part_content functions.

2011-05-27T23:18:57Z

Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions.

Use empty strings instead of NULL in format_reply structure.

2011-05-27T23:18:57Z

This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats.

Integrate reply_part_content function into reply_part function.

2011-05-27T23:18:57Z

After the last patch to eliminate some redundant code paths in reply_part, the reply_part_content function was only being called once. Disolving the function and integrating its contents into the reply_part function makes things a little simpler, and frees up some name space that will be needed in the next patch.

Simplify reply_part function to eliminate redundant code paths.

2011-05-27T23:18:57Z

This is the same logic but with less code.