notmuch/notmuch-reply.c, branch feature/git-remote

CLI/reply: support --duplicate argument

2022-07-30T11:45:15Z

We want the reply used to match that shown e.g. in the emacs interface. As a first step provide that functionality on the command line. Schema does not need updating as the duplicate key was already present (with a constant value of 1).

CLI/show: support --duplicate for structured output

2022-07-30T11:41:50Z

This introduces a new mandatory key for message structures, namely "duplicate". Per convention in devel/schemata this does _not_ increase the format version. This means that clients are responsible for checking that it exists, and not crashing if it does not. The main functional change is teaching mime_node_open to understand a 'duplicate' argument. Support for --duplicate in notmuch-reply would make sense, but we defer it to a later commit.

CLI/{count, dump, reindex, reply, show}: enable sexp queries

2021-09-05T00:07:19Z

The change in each case is to call notmuch_query_create_with_syntax, relying on the already inherited shared options. As a bonus we get improved error handling from the new query creation API. The remaining subcommand is 'tag', which is a bit trickier.

CLI: make variable n_requested_db_uuid file scope.

2021-09-05T00:07:19Z

It turns out that now that we pass an open database into the subcommands, it is easy to check any requested uuid against the database at the same time as we process the other shared arguments. This results in overall less boilerplate code, as well as making a CLI scope function and variable file scope in notmuch.c.

lib: consider all instances of Delivered-To header

2021-08-30T01:10:08Z

When using notmuch-reply and guessing the From: address from Delivered-To headers, I had the wrong address chosen today. This was because the messages from the notmuch list contain these headers in this order: Delivered-To: hannu.hartikainen@gmail.com ... Delivered-To: hannu@hrtk.in In my .notmuch-config I have the following configuration: primary_email=hannu@hrtk.in other_email=hannu.hartikainen@gmail.com;... Before this change, notmuch-reply would guess From: @gmail.com because that is the first Delivered-To header present. After the change, the primary address is chosen as I would expect.

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

cli: run uncrustify

2021-03-13T12:45:34Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory Line breaks were then adjusted manually to keep argc and argv together.

CLI/reply: convert to new config framework

2021-02-06T23:21:23Z

This is messier than some of the other conversions because the extensive use of 'config' as a talloc context.

CLI: add (unused) database argument to subcommands.

2021-02-06T23:05:19Z

This will allow transitioning individual subcommands to the new configuration framework. Eventually when they are all converted we can remove the notmuch_config_t * argument. For now, live with the parameter shadowing in some some subcommands; it will go away when they are converted.

cli/reply: Ignore PKCS#7 wrapper parts when replying

2020-05-23T01:11:25Z

When composing a reply, no one wants to see this line in the proposed message: Non-text part: application/pkcs7-mime So we hide it, the same way we hide PGP/MIME cruft. Signed-off-by: Daniel Kahn Gillmor