notmuch/notmuch-restore.c, branch 0.13.1

lib/cli: Make notmuch_database_open return a status code

2012-05-05T13:11:57Z

It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest of atomicity, this also updates every use in the CLI so that notmuch still compiles. Since this patch does not update the bindings, the Python bindings test fails.

Use notmuch_database_destroy instead of notmuch_database_close

2012-04-28T12:27:33Z

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

cli: refactor "notmuch restore" message tagging into a separate function

2012-03-31T00:22:44Z

Refactor to make tagging code easier to reuse in the future. No functional changes. Signed-off-by: Jani Nikula

notmuch-restore: convert to command-line-arguments

2011-12-09T00:24:24Z

The new argument handling is a bit more concise, and bit more flexible. It allows the input file name to go before the --accumulate option.

xregcomp: don't consider every regex compilation failure an internal error.

2011-10-31T02:10:38Z

This pushes the error handling up one step, but makes the function more flexible. Running out of memory still triggers an internal error, in the spirit of other xutils functions.

notmuch-restore: check for extra arguments.

2011-10-23T13:27:57Z

We consider it an error to pass more than one file to restore, since extra ones are ignored.

notmuch-restore: implement --accumulate option

2011-10-23T13:27:57Z

Modify command line argument handling to take a --accumulate flag. Test for extra arguments beyond the input file. The --accumulate switch causes the union of the existing and new tags to be applied, instead of replacing each message's tags as they are read in from the dump file. Based on a patch by Thomas Schwinge: id:"1317317857-29636-1-git-send-email-thomas@schwinge.name"

cli: change argument parsing convention for subcommands

2011-10-22T22:42:54Z

previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command line arguments in the subcommand, including possibly using off-the-shelf routines like getopt_long that expect the name of the command in argv[0].

lib: make find_message{,by_filename) report errors

2011-10-04T04:55:29Z

Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my mail "id:871uv2unfd.fsf@gmail.com" Make these functions accept a pointer to 'notmuch_message_t' as argument and return notmuch_status_t which may be used to check for any error condition. restore: Modify for the new notmuch_database_find_message() new: Modify for the new notmuch_database_find_message_by_filename()

lib: Rework interface for maildir_flags synchronization

2010-11-11T11:40:19Z

Instead of having an API for setting a library-wide flag for synchronization (notmuch_database_set_maildir_sync) we instead implement maildir synchronization with two new library functions: notmuch_message_maildir_flags_to_tags and notmuch_message_tags_to_maildir_flags These functions are nicely documented here, (though the implementation does not quite match the documentation yet---as plainly evidenced by the current results of the test suite).