notmuch/notmuch-restore.c, branch 0.15.2

dump/restore: Use Xapian queries for batch-tag format

2013-01-07T02:40:32Z

This switches the new batch-tag format away from using a home-grown hex-encoding scheme for message IDs in the dump to simply using Xapian queries with Xapian quoting syntax. This has a variety of advantages beyond presenting a cleaner and more consistent interface. Foremost is that it will dramatically simplify the quoting for batch tagging, which shares the same input format. While the hex-encoding is no better or worse for the simple ID queries used by dump/restore, it becomes onerous for general-purpose queries used in batch tagging. It also better handles strange cases like "id:foo and bar", since this is no longer syntactically valid.

restore: Make missing messages non-fatal (again)

2013-01-07T02:39:23Z

Previously, restore would abort if a message ID in the dump was missing. Furthermore, it would only report this as a warning. This patch makes it distinguish abort-worthy lookup failures like out-of-memory from non-fatal failure to find a message ID. The former is reported as an error and causes restore to abort, while the latter is reported as a warning and does not cause an abort. This restores 0.14's non-fatal handling of missing message IDs in restore (though 0.14 also considered serious errors non-fatal; we retain the new and better handling of serious errors).

notmuch-restore: handle empty input file, leading blank lines and comments.

2013-01-06T14:04:19Z

This patch corrects several undesirable behaviours: 1) Empty files were not detected, leading to buffer read overrun. 2) An initial blank line cause restore to silently abort 3) Initial comment line caused format detection to fail

notmuch-restore: use debug version of talloc_strndup

2012-12-31T01:12:11Z

This gives line numbers for better debugging.

notmuch-restore: allocate a temporary talloc context for each line parsed.

2012-12-23T03:19:43Z

This lets the high level code in notmuch restore be ignorant about what the lower level code is doing as far as allocating memory.

tag-utils: use the tag_opt_list_t as talloc context, if possible.

2012-12-23T03:13:15Z

The memory usage discipline of tag_op_list_t is never to free the internal array of tag operations before freeing the whole list, so it makes sense to take advantage of hierarchical de-allocation by talloc. By not relying on the context passed into tag_parse_line, we can allow tag_op_list_t structures to live longer than that context.

notmuch-restore: fix return value propagation

2012-12-23T03:11:47Z

Previously notmuch_restore_command returned 0 if tag_message returned a non-zero (failure) value. This is wrong, since non-zero status indicates something mysterious went wrong with retrieving the message, or applying it. There was also a failure to check or propagate the return value from tag_op_list_apply in tag_message.

notmuch-restore: normalize case of error messages.

2012-12-09T17:33:34Z

In English, (unlike German) one does not capitalize the first word after a colon.

notmuch-restore: add support for input format 'batch-tag'

2012-12-09T17:33:34Z

This can be enabled with the new --format=batch-tag command line option to "notmuch restore". The input must consist of lines of the format: +|- [...] [--] id: Each line is interpreted similarly to "notmuch tag" command line arguments. The delimiter is one or more spaces ' '. Any characters in and MAY be hex encoded with %NN where NN is the hexadecimal value of the character. Any ' ' and '%' characters in and MUST be hex encoded (using %20 and %25, respectively). Any characters that are not part of or MUST NOT be hex encoded. Leading and trailing space ' ' is ignored. Empty lines and lines beginning with '#' are ignored. Commit message mainly stolen from Jani's batch tagging commit, to follow.

notmuch-restore: tidy formatting

2012-11-16T12:46:07Z

This is again the work of uncrustify. I remember there is some controversy about "! foo" versus "!foo", but in context I think "! foo" looks OK. Also, for functions "! foo (blah)" seems better than "!foo (blah)".