notmuch/notmuch-show.c, branch 0.31

cli/show: replace deprecated notmuch_message_get_flag

2020-07-18T14:03:28Z

This can be seen as moving an abort out of the library, into the CLI where we can both print to stderr and shut the process down without ill effect.

cli/show: If a leaf part has children, show them instead of omitting

2020-05-23T01:11:17Z

Until we did PKCS#7 unwrapping, no leaf MIME part could have a child. Now, we treat the unwrapped MIME part as the child of the PKCS#7 SignedData object. So in that case, we want to show it instead of deliberately omitting the content. This fixes the test of the protected subject in id:smime-onepart-signed@protected-headers.example. Signed-off-by: Daniel Kahn Gillmor

notmuch-show.c: add an option for messages to be returned unthreaded

2020-03-20T01:05:47Z

This adds a --unthreaded option to notmuch show to tell it to return the matching messages in an unthreaded order (so just by date). To make it easier for users, in particular for notmuch-tree.el, we output each message with the same "nesting" as if it were an entire thread in its own right. amended by db: s/status= /status = /

notmuch-show: run uncrustify

2019-07-05T15:54:36Z

This is the result of running: $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h In the top level source directory. I was using uncrustify 0.68.1+dfsg1-2. I do not know why these changes were not caught in 33382c2b5ba2537952a60ea378feff36961e4713 Signed-off-by: Daniel Kahn Gillmor

cli: run uncrustify

2019-06-14T10:41:27Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory

CLI: replace some constructs with more uncrustify friendly ones

2019-06-14T10:41:27Z

In particular - use (bool) instead of !! - cuddle the opening parens of function calls - add parens in some ternery operators

cli/show: add information about which headers were protected

2019-05-29T11:11:50Z

The header-mask member of the per-message crypto object allows a clever UI frontend to mark whether a header was protected (or not). And if it was protected, it contains enough information to show useful detail to an interested user. For example, an MUA could offer a "show what this message's Subject looked like on the wire" feature in expert mode. As before, we only handle Subject for now, but we might be able to handle other headers in the future. Signed-off-by: Daniel Kahn Gillmor Amended by db: tweaked schemata notation.

cli/show: emit payload subject instead of outside subject

2019-05-29T11:05:01Z

Correctly fix the two outstanding tests so that the protected (hidden) subject is properly reported. Signed-off-by: Daniel Kahn Gillmor

cli/show: emit headers after emitting body

2019-05-29T11:02:32Z

This paves the way for emitting protected headers after verification and decryption, because it means that the headers will only be emitted after the body has been parsed. Signed-off-by: Daniel Kahn Gillmor

cli/show: emit new whole-message crypto status output

2019-05-26T11:20:23Z

This allows MUAs that don't want to think about per-mime-part cryptographic status to have a simple high-level overview of the message's cryptographic state. Sensibly structured encrypted and/or signed messages will work fine with this. The only requirement for the simplest encryption + signing is that the message have all of its encryption and signing protection (the "cryptographic envelope") in a contiguous set of MIME layers at the very outside of the message itself. This is because messages with some subparts signed or encrypted, but with other subparts with no cryptographic protection is very difficult to reason about, and even harder for the user to make sense of or work with. For further characterization of the Cryptographic Envelope and some of the usability tradeoffs, see here: https://dkg.fifthhorseman.net/blog/e-mail-cryptography.html#cryptographic-envelope