notmuch/notmuch-show.c, branch 0.35

CLI: print extra headers only for non-replies

2022-01-19T01:26:45Z

If in the future we decide to output extra headers for replies, this should be controlled by a separate configuration option.

CLI: print extra headers in structured output

2022-01-18T12:11:06Z

This is based on a patch from Johan Parin [1], which is in turn responding to a bug report / feature requiest from Jan Malkhovski. The update to the structured output documented in schemata is intended to be upward compatible, so the format version stays the same [1]: id:20191116162723.18343-1-johan.parin@gmail.com [2]: id:87h8sdemnr.fsf@oxij.org

CLI/{count, dump, reindex, reply, show}: enable sexp queries

2021-09-05T00:07:19Z

The change in each case is to call notmuch_query_create_with_syntax, relying on the already inherited shared options. As a bonus we get improved error handling from the new query creation API. The remaining subcommand is 'tag', which is a bit trickier.

CLI: make variable n_requested_db_uuid file scope.

2021-09-05T00:07:19Z

It turns out that now that we pass an open database into the subcommands, it is easy to check any requested uuid against the database at the same time as we process the other shared arguments. This results in overall less boilerplate code, as well as making a CLI scope function and variable file scope in notmuch.c.

CLI/show: accept --sort

2021-07-03T23:27:33Z

Add the command-line option --sort to the show command of the CLI notmuch interface, with the same possible values as the same option in notmuch search.

cli/show: produce "email" element in sigstatus

2021-06-26T16:07:47Z

When the certificate that signs a message is known to be valid, GMime is capable of reporting on the e-mail address embedded in the certificate. We pass this information along to the caller of "notmuch show", as often only the e-mail address of the certificate has actually been checked/verified. Furthermore, signature verification should probably at some point compare the e-mail address of the caller against the sender address of the message itself. Having to parse what gmime thinks is a "userid" to extract an e-mail address seems clunky and unnecessary if gmime already thinks it knows what the e-mail address is. See id:878s41ax6t.fsf@fifthhorseman.net for more motivation and discussion. Signed-off-by: Daniel Kahn Gillmor

CLI: drop notmuch_config_t from subcommand interface.

2021-04-07T00:32:36Z

At this point it is unused in all subcommands.

CLI/show: complete conversion to new configuration framework.

2021-03-20T01:06:19Z

In order to open the database in main() for this command, we may need to re-open it in the (possibly less common) case where crypto options require write access.

cli: run uncrustify

2021-03-13T12:45:34Z

This is the result of running $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h in the top level source directory Line breaks were then adjusted manually to keep argc and argv together.

CLI/show: mostly switch show to new config framework

2021-02-06T23:27:54Z

This will need some cleanup when the transition completes, and we stop passing notmuch_config_t structs to the subcommands. Unlike the general case, we open the database in the subcommand, since we don't know whether it should be opened read/write until we parse the command line arguments. Add a test to make sure passing config file on the command line is not broken by these or future config related changes.