notmuch/notmuch-show.c, branch 0.4

notmuch show: Add a --format=mbox option

2010-06-09T02:45:54Z

We don't love the mbox format, but it's still sometimes the most practical way to share a collection of messages as a single file. Here we implement the "mboxrd" variant of the mbox file format. This variant applies reversible escaping by prefixing a '>' character to all lines in the email messages matching the regular expression: "^>*From " This allows the escaping to be reliably removed. A reader should remove a '>' from any line matching the regular expression: "^>>*From " More details on the mboxrd formats (and others as well) can be found here: http://homepage.ntlworld.com/jonathan.deboynepollard/FGA/mail-mbox-formats.html

Fix minor style issues in show_part_content function.

2010-06-05T15:47:13Z

I was recently editing the code in this function and decided to clean it up a bit.

Avoid giving GMime a NULL MIME-stream filter.

2010-06-05T15:40:26Z

Micah Anderson reported an issue where a message failed to display in the emacs interface, (it instead gave an error, "json-read-string: Bad string format"). Micah tracked this down to the json output from "notmuch show" being interrupted by a GMime error message: gmime-CRITICAL **: g_mime_stream_filter_add: assertion `GMIME_IS_FILTER (filter) I tracked this down further to notmuch passing a NULL value to g_mime_stream_filter_add. And this was due to calling g_mime_filter_charset_new with a value of "unknown-8bit". So we add a test message withe a Conten-Type of "text/plain; charset=unknown-8bit" from Micah's message. Then we fix "notmuch show" to test for NULL before calling g_mime_stream_filter_add. Bug fixed.

json: Replace `date_unix' with `timestamp' in show output

2010-04-22T21:52:32Z

Search output was already using `timestamp' for a very similar field, so follow that.

notmuch: Correctly terminate text/* parts in JSON output

2010-04-05T17:57:23Z

Text parts returned by `g_mime_stream_mem_get_byte_array()' are not NULL terminated strings - add `json_quote_chararray()' to handle them correctly.

notmuch: Add a 'part' subcommand

2010-04-02T08:43:03Z

A new 'part' subcommand allows the user to extract a single part from a MIME message. Usage: notmuch part --part= The search terms must match only a single message (e.g. id:foo@bar.com). The part number specified refers to the part identifiers output by `notmuch show'. The content of the part is written the stdout with no formatting or identification marks. It is not JSON formatted.

notmuch-show: Add unix and relative dates to the JSON output

2010-04-02T08:25:38Z

Include a 'date_unix' and 'date_relative' field in the JSON output for each message. 'date_relative' can be used by a UI implementation, whereas 'date_unix' is useful when scripting.

Setup the GMimeStream only when needed

2010-04-01T21:27:01Z

I ran into this while looking at the vim plugin. Vim's system() call redirects output to a file and it was missing many of the part{ lines. If stream_stdout is setup too early, it will overwrite the part start when notmuch is redirected to a file. Reviewed-by Carl Worth : GMime is calling fseek before every write to reset the FILE* to the position it believes is correct based on the writes it has seen. Our code was getting incorrect results because our GMime writes were interleaved with non-GMime writes via printf. The bug appears when writing to a file because it's seekable, but not when writing to a pipe which is not.

notmuch-show: add tags to json output

2010-03-11T12:30:46Z

The previous json patches forgot to add the notmuch tags to the json output. This is inconsistent to the text output so here they are. We just output a 'tags' field that sends notmuch tags as a json array. Signed-off-by: Sebastian Spaeth

notmuch show: Don't show empty headers.

2010-03-09T18:12:58Z

This is a fairly old regression. There has always been code to avoid printing empty headers (such as Cc or Bcc with no values), but it has been broken since notmuch_message_get_header was changed to return an empty string rather than a NULL pointer for these fields.