notmuch/notmuch-tag.c, branch 0.13

lib/cli: Make notmuch_database_open return a status code

2012-05-05T13:11:57Z

It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest of atomicity, this also updates every use in the CLI so that notmuch still compiles. Since this patch does not update the bindings, the Python bindings test fails.

Use notmuch_database_destroy instead of notmuch_database_close

2012-04-28T12:27:33Z

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

cli: refactor "notmuch tag" query tagging into a separate function

2012-03-31T00:22:31Z

Refactor to make tagging code easier to reuse in the future. No functional changes. Signed-off-by: Jani Nikula

cli: refactor "notmuch tag" data structures for tagging operations

2012-03-31T00:20:36Z

To simplify code, keep all tagging operations in a single array instead of separate add and remove arrays. Apply tag changes in the order specified on the command line, instead of first removing and then adding the tags. This results in a minor functional change: If a tag is both added and removed, the last specified operation is now used. Previously the tag was always added. Change the relevant test to reflect the new behaviour. Signed-off-by: Jani Nikula

tag: remove unused attribute from notmuch_tag_command() arguments

2012-02-08T13:19:29Z

Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them.

Silence buildbot warnings about unused results

2012-01-21T12:49:50Z

This ignores the results of the two writes in sigint handlers even harder than before. While my libc lacks the declarations that trigger these warnings, this can be tested by adding the following to notmuch.h: __attribute__((warn_unused_result)) ssize_t write(int fd, const void *buf, size_t count);

notmuch: Quiet buildbot warnings.

2011-12-21T11:32:16Z

Cast away the result of various *write functions. Provide a default value for some variables to avoid "use before set" warnings.

tag: Automatically limit to messages whose tags will actually change.

2011-11-28T14:54:42Z

This optimizes the user's tagging query to exclude messages that won't be affected by the tagging operation, saving computation and IO for redundant tagging operations. For example, notmuch tag +notmuch to:notmuch@notmuchmail.org will now use the query ( to:notmuch@notmuchmail.org ) and (not tag:"notmuch") In the past, we've often suggested that people do this exact transformation by hand for slow tagging operations. This makes that unnecessary.

cli: change argument parsing convention for subcommands

2011-10-22T22:42:54Z

previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command line arguments in the subcommand, including possibly using off-the-shelf routines like getopt_long that expect the name of the command in argv[0].

Remove some variables which were set but not used.

2011-05-11T20:27:14Z

gcc (at least as of version 4.6.0) is kind enough to point these out to us, (when given -Wunused-but-set-variable explicitly or implicitly via -Wunused or -Wall). One of these cases was a legitimately unused variable. Two were simply variables (named ignored) we were assigning only to squelch a warning about unused function return values. I don't seem to be getting those warnings even without setting the ignored variable. And the gcc docs. say that the correct way to squelch that warning is with a cast to (void) anyway.