notmuch/notmuch-tag.c, branch 0.15.2

cli: propagate batch tagging warnings to exit value

2013-01-14T23:47:14Z

In case last input for batch tagging was either invalid or skippable line, notmuch command exited with non-zero value. After this change if there is at least one invalid line, notmuch command will exit with non-zero value. Additionally, skipped lines (last or other) doesn't cause non-zero value to be returned.

cli: bail out and propagate tagging errors in notmuch tag

2013-01-10T03:08:48Z

Checking and propagating tag_op_list_apply() errors is especially important with batch tagging, as the processing of the batch input would not stop otherwise. Additionally this sets the exit code, which is useful in scripts. Amended by: David Bremner

cli: add support for batch tagging operations to "notmuch tag"

2013-01-08T00:48:54Z

Add support for batch tagging operations through stdin to "notmuch tag". This can be enabled with the new --batch command line option to "notmuch tag". The input must consist of lines of the format: +|- [...] [--] [...] Each line is interpreted similarly to "notmuch tag" command line arguments. The delimiter is one or more spaces ' '. Any characters in MAY be hex encoded with %NN where NN is the hexadecimal value of the character. Any ' ' and '%' characters in and MUST be hex encoded (using %20 and %25, respectively). For future-proofing, any '"' characters in SHOULD be hex-encoded. Any characters that are not part of or MUST NOT be hex encoded. is passed verbatim to Xapian Leading and trailing space ' ' is ignored. Empty lines and lines beginning with '#' are ignored. Signed-off-by: Jani Nikula Hacked-like-crazy-by: David Bremner

notmuch-tag.c: convert to use tag-util

2013-01-08T00:42:21Z

Command line parsing is factored out into a function parse_tag_command_line in tag-util.c. There is some duplicated code eliminated in tag_query, and a bunch of translation from using the bare tag_op structs to using that tag-utils API.

util: Factor out boolean term quoting routine

2013-01-07T02:39:36Z

This is now a generic boolean term quoting function. It performs minimal quoting to produce user-friendly queries. This could live in tag-util as well, but it is really nothing specific to tags (although the conventions are specific to Xapian). The API is changed from "caller-allocates" to "readline-like". The scan for max tag length is pushed down into the quoting routine. Furthermore, this now combines the term prefix with the quoted term; arguably this is just as easy to do in the caller, but this will nicely parallel the boolean term parsing function to be introduced shortly. This is an amalgamation of code written by David Bremner and myself.

notmuch-tag: tidy formatting

2012-11-16T12:45:39Z

This is just the result of running uncrustify.

tag: Disallow adding malformed tags to messages

2012-10-27T12:32:44Z

This disallows adding empty tags, since nothing but confusion follows in their wake, and disallows adding tags that begin with "-" because they are also confusing, the tag "-" is impossible to remove using the CLI, and because the syntax for removing such tags conflicts with long argument syntax. This does not place any restrictions on what tags can be removed, as that would make it difficult for people who have the misfortune of already having malformed tags to remove these tags.

lib/cli: Make notmuch_database_open return a status code

2012-05-05T13:11:57Z

It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest of atomicity, this also updates every use in the CLI so that notmuch still compiles. Since this patch does not update the bindings, the Python bindings test fails.

Use notmuch_database_destroy instead of notmuch_database_close

2012-04-28T12:27:33Z

Adapt the notmuch binaries source to the notmuch_database_close split. Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>

cli: refactor "notmuch tag" query tagging into a separate function

2012-03-31T00:22:31Z

Refactor to make tagging code easier to reuse in the future. No functional changes. Signed-off-by: Jani Nikula